Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] xen/pvcalls: fix unsigned less than zero error check
To:     Juergen Gross <jgross@suse.com>,
        Colin King <colin.king@canonical.com>,
        xen-devel@lists.xenproject.org
References: <20171103084202.27790-1-colin.king@canonical.com>
 <2116793f-cd52-a99f-772e-5dcb768ad411@suse.com>
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <81dba278-f38e-3043-c1f7-2a0f00ae07d7@oracle.com>
Date:   Wed, 8 Nov 2017 16:20:32 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <2116793f-cd52-a99f-772e-5dcb768ad411@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/03/2017 05:01 AM, Juergen Gross wrote:
> On 03/11/17 09:42, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The check on bedata->ref is never true because ref is an unsigned
>> integer. Fix this by assigning signed int ret to the return of the
>> call to gnttab_claim_grant_reference so the -ve return can be checked.
>>
>> Detected by CoverityScan, CID#1460358 ("Unsigned compared against 0")
>>
>> Fixes: 219681909913 ("xen/pvcalls: connect to the backend")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>


Applied to for-linus-4.15.

-boris

From 1583034918072649834@xxx Fri Nov 03 09:02:23 +0000 2017
X-GM-THRID: 1583033712795190059
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread