Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <b6efd4c2-e572-748a-848b-d714af3deedc@canonical.com>
References: <b6efd4c2-e572-748a-848b-d714af3deedc@canonical.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed, 8 Nov 2017 10:53:58 -0800
Message-ID: <CA+55aFz=fim-At4bdVz0Jte8WNU2BwUk_DHMw53hnpY+Q7LuSA@mail.gmail.com>
Subject: Re: [PATCH] apparmor: fix off-by-one comparison on MAXMAPPED_SIG
To:     John Johansen <john.johansen@canonical.com>
Cc:     LKLM <linux-kernel@vger.kernel.org>,
        Colin Ian King <colin.king@canonical.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 8, 2017 at 8:09 AM, John Johansen
<john.johansen@canonical.com> wrote:
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: John Johansen <john.johansen@canonical.com>

This sign-off chain is odd. It implies that the patch came from Colin
King, bnut it lacks authorship attribution.

So who authored this?

If it was Colin, there should have been a

    From: Colin Ian King <colin.king@canonical.com>

at the top.

So either the authorship is broken, or the sign-off chain is. Which is it?

              Linus

From 1583514887991701392@xxx Wed Nov 08 16:11:18 +0000 2017
X-GM-THRID: 1583514887991701392
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread