Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171109083452.GA10787@infradead.org>
References: <20171109061652.14948-1-luc.vanoostenryck@gmail.com>
 <20171109061652.14948-3-luc.vanoostenryck@gmail.com> <20171109083452.GA10787@infradead.org>
From:   Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Date:   Thu, 9 Nov 2017 14:13:07 +0100
Message-ID: <CAMHZB6H4dGwMM+nPbDg0SEDBkRF7_R_LZ-bMWUzreBYDj3U3Sg@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] sparc: pass endianness info to sparse
To:     Christoph Hellwig <hch@infradead.org>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Sam Ravnborg <sam@ravnborg.org>, sparclinux@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Babu Moger <babu.moger@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 9, 2017 at 9:34 AM, Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Nov 09, 2017 at 07:16:52AM +0100, Luc Van Oostenryck wrote:
>> sparc is big-endian only but sparse assumes the same endianness
>> as the building machine.
>> This is problematic for code which expect __BYTE_ORDER__ being
>> correctly predefined by the compiler which sparse can then
>> pre-process differently from what gcc would, depending on the
>> building machine endianness.
>>
>> Fix this by letting sparse know about the architecture endianness.
>
> You're posted patches for this for about half a dozen architectures
> now, but we also now have generic Kconfig symbols for the byte order.
>
> I'd much rather see this done in generic code than hacking it up
> everywhere.

OK, when I wrote these patch (in June, IIRC) there wasn't yet the
generic Kconfig symbol. I'll see what can now be generic and what
need to stay specific (for example, ARM need __ARME{L,B}__,
ARM64 & MIPS are in the same situation as are a few others archs).

-- Luc Van Oostenryck

From 1583576828395367221@xxx Thu Nov 09 08:35:49 +0000 2017
X-GM-THRID: 1583568171624506780
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread