Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   KY Srinivasan <kys@microsoft.com>
To:     Haiyang Zhang <haiyangz@microsoft.com>,
        Long Li <longli@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Paul Meyer <Paul.Meyer@microsoft.com>,
        Long Li <longli@microsoft.com>
Subject: RE: [Revised PATCH v2] hv: kvp: Avoid reading past allocated blocks
 from KVP file
Thread-Topic: [Revised PATCH v2] hv: kvp: Avoid reading past allocated blocks
 from KVP file
Thread-Index: AQHTU0HFQdcCAc3/YUGJc52biUWrO6MKk1kAgABGewA=
Date:   Wed, 8 Nov 2017 18:34:37 +0000
Message-ID: <DM5PR21MB047624EF7037FFADCC66719BA0560@DM5PR21MB0476.namprd21.prod.outlook.com>
References: <20171101184526.1689-1-longli@exchange.microsoft.com>
 <CY4PR2101MB0867C3F885E41BA86EBF6339CA560@CY4PR2101MB0867.namprd21.prod.outlook.com>
In-Reply-To: <CY4PR2101MB0867C3F885E41BA86EBF6339CA560@CY4PR2101MB0867.namprd21.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=haiyangz@microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-11-08T14:21:54.5097748Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic;
 Sensitivity=General
x-originating-ip: [2001:4898:80e8:4::11a]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;DM5PR21MB0858;6:XtWj/H44P0/ky1cEj3AXTdsYdYeF/JztwGRSIkf4WFNgEGww6tfREPTG8sDJgwKeLva7Jc2X4XDIv7pO7ZdukhsqTzzNdtvvXPNGXnmjulis6plNqItftYhGP8e6dgT+VZAoKWkFD3xoPXMzPfOm7p7NYL262hIExC5WPiJ/8JhzgpLg3otUc1s/K25essGAtLCWqdztOy/xseXlQ4eyjFO1wzR4RpJ8VxgGc0RD8SdD+KE0xMrbb0G1j8pXroqybZ4qfmTM/BPY54sPxqsCEanCTorBqPJmTJYA5dbIsTnOXKoWs3YR+euzVWXPPFlxOTB+aXn86eef8jqXmBNo8ZoEaFyZuwu4oKd3SK6oPDg=;5:Ny3ARabTrWXu0688f/s3ZuCDVyzJygHyPW4HXFD10f6hkauIgio9uBWf5IDoGtEnW/3ikSHW+I4u1/NXMYgCa2O0cNI08Na/7fWsAisHdvbGlyGMoqkkWoNE1+rG3Ppc2wSDjh8cEwj2NFZegLDN7UtbysCiDWWGex/wSUinI/s=;24:eXGj/JxRmRCaF3QTA0ZbrgMMxjpm7C6AQkfLaZiuL3VNLDNx0zyjllLKza3DLb9ddRrPyqRCFXb5S0hRSd1GC/QKenBlNBvFz1I+OqMbkaU=;7:7pzQkNaLkcwnw/hQrJ8fIrDrao6pyfh2Ygap4GHvbT3tpojCgBDVvfuMsxvWOhUD6bSFEat4EYJtOrfisv1nNhAqA4vF+pCbTDGCbLKE3PUtLGSDJ+v0Q1Xy614+2jjb3CHZ80d2n3lTnh8SJWj6iVhcL0gu7eFyH0hIzZGyCnXW6q0otWuORyf8SCtckxP639xVK5d5UNyhYgbqdyx77LGcp691WVwO6yG6d1okoYDfV7V5sMb/DxYm1yQsRwR0
x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR;
x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(39860400002)(47760400005)(189002)(199003)(13464003)(8990500004)(229853002)(305945005)(478600001)(7736002)(1511001)(8676002)(10090500001)(5660300001)(110136005)(54906003)(8936002)(2906002)(74316002)(3280700002)(53546010)(2950100002)(68736007)(6436002)(2501003)(81156014)(106356001)(316002)(55016002)(7696004)(3660700001)(105586002)(86612001)(6116002)(2201001)(6246003)(50986999)(102836003)(25786009)(54356999)(86362001)(53936002)(22452003)(2900100001)(2561002)(76176999)(77096006)(14454004)(4326008)(6506006)(99286004)(10290500003)(97736004)(53366004)(966005)(107886003)(9686003)(189998001)(53376002)(33656002)(2421001)(81166006)(101416001)(6306002)(10090945008);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR21MB0858;H:DM5PR21MB0476.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en;
x-ms-office365-filtering-correlation-id: 918d7a8b-48e4-40c7-676d-08d526d75def
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603249);SRVR:DM5PR21MB0858;
x-ms-traffictypediagnostic: DM5PR21MB0858:
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=kys@microsoft.com; 
x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055)(140211028294663);
x-microsoft-antispam-prvs: <DM5PR21MB0858B3B74FC00DD18A7A6226A0560@DM5PR21MB0858.namprd21.prod.outlook.com>
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231021)(100000703101)(100105400095)(6055026)(61426038)(61427038)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR21MB0858;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR21MB0858;
x-forefront-prvs: 0485417665
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 918d7a8b-48e4-40c7-676d-08d526d75def
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2017 18:34:37.7181
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR21MB0858
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Haiyang Zhang
> Sent: Wednesday, November 8, 2017 6:22 AM
> To: Long Li <longli@microsoft.com>; KY Srinivasan <kys@microsoft.com>;
> Stephen Hemminger <sthemmin@microsoft.com>;
> devel@linuxdriverproject.org; linux-kernel@vger.kernel.org
> Cc: Paul Meyer <Paul.Meyer@microsoft.com>; Long Li
> <longli@microsoft.com>
> Subject: RE: [Revised PATCH v2] hv: kvp: Avoid reading past allocated blo=
cks
> from KVP file
>=20
>=20
>=20
> > -----Original Message-----
> > From: Long Li [mailto:longli@exchange.microsoft.com]
> > Sent: Wednesday, November 1, 2017 2:45 PM
> > To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> > <haiyangz@microsoft.com>; Stephen Hemminger
> > <sthemmin@microsoft.com>; devel@linuxdriverproject.org; linux-
> > kernel@vger.kernel.org
> > Cc: Paul Meyer <Paul.Meyer@microsoft.com>; Long Li
> > <longli@microsoft.com>
> > Subject: [Revised PATCH v2] hv: kvp: Avoid reading past allocated block=
s
> > from KVP file
> >
> > [This sender failed our fraud detection checks and may not be who they
> > appear to be. Learn about spoofing at http://aka.ms/LearnAboutSpoofing]
> >
> > From: Paul Meyer <Paul.Meyer@microsoft.com>
> >
> > While reading in more than one block (50) of KVP records, the allocatio=
n
> > goes per block, but the reads used the total number of allocated record=
s
> > (without resetting the pointer/stream). This causes the records buffer =
to
> > overrun when the refresh reads more than one block over the previous
> > capacity (e.g. reading more than 100 KVP records whereas the in-memory
> > database was empty before).
> >
> > Fix this by reading the correct number of KVP records from file each ti=
me.
> >
> > Changes since v1:
> > 1. Properly wrapped comment texts.
> > 2. Added the 2nd Signed-off-by.
> >
> > Signed-off-by: Paul Meyer <Paul.Meyer@microsoft.com>
> > Signed-off-by: Long Li <longli@microsoft.com>
>=20
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>

I will take this patch.

K. Y

From 1583508147071049126@xxx Wed Nov 08 14:24:09 +0000 2017
X-GM-THRID: 1582890557754274865
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread