Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] selftests: kselftest.h: fix compilation errors
To:     Lei Yang <Lei.Yang@windriver.com>, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org, Shuah Khan <shuahkh@osg.samsung.com>
References: <20171108052410.14616-1-Lei.Yang@windriver.com>
From:   Shuah Khan <shuahkh@osg.samsung.com>
Message-ID: <0ac0008c-df35-6df3-03c9-5698815d18b2@osg.samsung.com>
Date:   Wed, 8 Nov 2017 08:26:16 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171108052410.14616-1-Lei.Yang@windriver.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/07/2017 10:24 PM, Lei Yang wrote:
> In next branch, Various build failed with:
> 
> In file included from membarrier_test.c:8:0:
> ../kselftest.h: In function ‘ksft_print_header’:
> ../kselftest.h:61:3: error: expected ‘)’ before ‘printf’
>    printf("TAP version 13\n");
>    ^
> ../kselftest.h:62:1: error: expected expression before ‘}’ token
>  }
>  ^
> 
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
>  tools/testing/selftests/kselftest.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
> index d6732ba312ef..acc98a5c3d73 100644
> --- a/tools/testing/selftests/kselftest.h
> +++ b/tools/testing/selftests/kselftest.h
> @@ -57,7 +57,7 @@ static inline int ksft_get_error_cnt(void) { return ksft_cnt.ksft_error; }
>  
>  static inline void ksft_print_header(void)
>  {
> -	if (!(getenv("KSFT_TAP_LEVEL"))
> +	if (!(getenv("KSFT_TAP_LEVEL")))
>  		printf("TAP version 13\n");
>  }
>  
> 

Thanks for the patch. It was a mistake that the original patch
ended up in the linux-kselftest next branch. My bad. I ended up
committing the patch my mistake. It is now removed.

thanks,
-- Shuah

From 1583483204746654793@xxx Wed Nov 08 07:47:42 +0000 2017
X-GM-THRID: 1583483204746654793
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread