Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] selftests: futex: fix compilation error
To:     Lei Yang <Lei.Yang@windriver.com>
References: <1509941009-11521-1-git-send-email-Lei.Yang@windriver.com>
Cc:     linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <shuahkh@osg.samsung.com>,
        Shuah Khan <shuah@kernel.org>
From:   Shuah Khan <shuahkh@osg.samsung.com>
Message-ID: <6b0b866a-b142-8c07-41e3-d561d4b91fb3@osg.samsung.com>
Date:   Mon, 6 Nov 2017 16:45:30 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1509941009-11521-1-git-send-email-Lei.Yang@windriver.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/05/2017 09:03 PM, Lei Yang wrote:
> I run into below error when building futext
> /bin/sh: -c: line 5: syntax error: unexpected end of file
> 
> the closing ";" and "\" are necessary.
> My OS is "Ubuntu 14.04.5 LTS"
> 
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
>  tools/testing/selftests/futex/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index f0c0369..943f3a2 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -11,9 +11,9 @@ all:
>  		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
>  		mkdir $$BUILD_TARGET  -p;	\
>  		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> -		if [ -e $$DIR/$(TEST_PROGS) ]; then
> -			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
> -		fi
> +		if [ -e $$DIR/$(TEST_PROGS) ]; then \
> +			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
> +		fi \
>  	done
>  
>  override define RUN_TESTS
> 

Hmm. I don't see this error on linux_4.14-rc8?

Can you give more details on the gcc version you are using?

thanks,
-- Shuah

From 1583368255140838022@xxx Tue Nov 07 01:20:38 +0000 2017
X-GM-THRID: 1583288022901438905
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread