Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] selftests: futex: fix compilation error
To:     Shuah Khan <shuahkh@osg.samsung.com>
References: <1509941009-11521-1-git-send-email-Lei.Yang@windriver.com>
 <6b0b866a-b142-8c07-41e3-d561d4b91fb3@osg.samsung.com>
 <d83134db-ad68-cfa0-42ef-1db070b2c931@osg.samsung.com>
CC:     <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Shuah Khan <shuah@kernel.org>
From:   lei yang <lei.yang@windriver.com>
Message-ID: <af4b1c56-4056-96dd-a4ef-825157c56361@windriver.com>
Date:   Tue, 7 Nov 2017 09:18:47 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <d83134db-ad68-cfa0-42ef-1db070b2c931@osg.samsung.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2017年11月07日 07:48, Shuah Khan wrote:
> On 11/06/2017 04:45 PM, Shuah Khan wrote:
>> On 11/05/2017 09:03 PM, Lei Yang wrote:
>>> I run into below error when building futext
>>> /bin/sh: -c: line 5: syntax error: unexpected end of file
>>>
>>> the closing ";" and "\" are necessary.
>>> My OS is "Ubuntu 14.04.5 LTS"
>>>
>>> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
>>> ---
>>>   tools/testing/selftests/futex/Makefile | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
>>> index f0c0369..943f3a2 100644
>>> --- a/tools/testing/selftests/futex/Makefile
>>> +++ b/tools/testing/selftests/futex/Makefile
>>> @@ -11,9 +11,9 @@ all:
>>>   		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
>>>   		mkdir $$BUILD_TARGET  -p;	\
>>>   		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>>> -		if [ -e $$DIR/$(TEST_PROGS) ]; then
>>> -			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
>>> -		fi
>>> +		if [ -e $$DIR/$(TEST_PROGS) ]; then \
>>> +			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
>>> +		fi \
>>>   	done
>>>   
>>>   override define RUN_TESTS
>>>
>> Hmm. I don't see this error on linux_4.14-rc8?
>>
>> Can you give more details on the gcc version you are using?
>
> I meant gnumake version? I am not seeing the failure with what I am
> using

$ make -v
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for x86_64-pc-linux-gnu


Lei


> thanks,
> -- Shuah
>


From 1583362557738088358@xxx Mon Nov 06 23:50:04 +0000 2017
X-GM-THRID: 1583288022901438905
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread