Received: by 10.223.164.202 with SMTP id h10csp27735wrb; Thu, 9 Nov 2017 02:06:57 -0800 (PST) X-Google-Smtp-Source: ABhQp+SC0o4DcxHiUyJMMo0KpoYsWmVxBr9FAkiayzkyJpoEkbvAI4SNMWKnDbgiN0PLGKHMO7zl X-Received: by 10.101.80.10 with SMTP id f10mr3436873pgo.408.1510222017729; Thu, 09 Nov 2017 02:06:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510222017; cv=none; d=google.com; s=arc-20160816; b=BMWfvxtsEzGjToh481vhvvsnkI0Q4p8r3CeMiadtROgBaq0PQ+XmQlMmJBeb6w17+j IcFnyKheGWJeCInaKoEUu9by+3L2E4zgrn7QlGkAdNx4GG4yP1fysrVWRmBO/drIqIsT rM0+7bo5FsZNHxCmm6lNuv8EM6Cjz4hb9oO4g8V9Gpe+ETUd3k1fxmkOzIpDHvgeS6CF euFKAD8L8q3JyfEzygBwtsCNHD5ee+LybGXN3+lYocOYUD+oJNMyh/5Ek/tPmsU+RHgx qhOmXED1j4x+WK7UQY8+vmipRmcNNoy54YMOtrZnACpWFl9y9pFXjpArLXy/asn4e3eb cHvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from :arc-authentication-results; bh=2ff1xrMmK9O7SZPb8ySe74UFpxKNpRQB5rQd8pI7MzU=; b=fEYfmMxNseJU4O5DRmZIqfnWwU1OymEQrAocqXjNyXXHy/W99aG5A5Rl7rPH6wCJkS tArWWPQ479pmt5pcH7UHT8FIJIGG6VNEvRbljrEtsOz61ppDsjrYRADrykIzG3vFMS7u lEduvakBHKYbX9fI+Srl3ymi821cJ8GCTgh0PlroqiAI3VWpgpz3CwhaFWbAXE49R/we Wzi6DUtNDhT18PjLcwEjKcIqn3ci8iNElidRtzdlne3x+1mOU/DjozyAjKhCyoyD8QoL rrC4cIc+JK59qtFzh2MoaYFBEmIvEZJln8Lfvo4iTIP3DXEfzfvawrFFci7sLkGbtTaZ UqXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f15si5798468pgn.303.2017.11.09.02.06.37; Thu, 09 Nov 2017 02:06:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753938AbdKIKFn convert rfc822-to-8bit (ORCPT + 81 others); Thu, 9 Nov 2017 05:05:43 -0500 Received: from lhrrgout.huawei.com ([194.213.3.17]:39885 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752920AbdKIKFg (ORCPT ); Thu, 9 Nov 2017 05:05:36 -0500 Received: from 172.18.7.190 (EHLO LHREML714-CAH.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DSG53870; Thu, 09 Nov 2017 10:05:27 +0000 (GMT) Received: from FRAEML701-CAH.china.huawei.com (10.206.14.32) by LHREML714-CAH.china.huawei.com (10.201.108.37) with Microsoft SMTP Server (TLS) id 14.3.361.1; Thu, 9 Nov 2017 10:05:25 +0000 Received: from FRAEML521-MBX.china.huawei.com ([169.254.1.209]) by FRAEML701-CAH.china.huawei.com ([10.206.14.32]) with mapi id 14.03.0361.001; Thu, 9 Nov 2017 11:05:14 +0100 From: Gabriele Paoloni To: dann frazier CC: "catalin.marinas@arm.com" , "will.deacon@arm.com" , "robh+dt@kernel.org" , "frowand.list@gmail.com" , "bhelgaas@google.com" , "rafael@kernel.org" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "lorenzo.pieralisi@arm.com" , "mark.rutland@arm.com" , "brian.starkey@arm.com" , "olof@lixom.net" , "benh@kernel.crashing.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Linuxarm , "linux-pci@vger.kernel.org" , "minyard@acm.org" , John Garry , "xuwei (O)" , "zhichang.yuan" Subject: RE: [PATCH v10 6/9] LPC: Support the LPC host on Hip06/Hip07 with DT bindings Thread-Topic: [PATCH v10 6/9] LPC: Support the LPC host on Hip06/Hip07 with DT bindings Thread-Index: AQHTTz56kIAHE/7yvUqnHZAP3mes/aMLOP0AgACqu6A= Date: Thu, 9 Nov 2017 10:05:14 +0000 Message-ID: References: <1509120687-7352-1-git-send-email-gabriele.paoloni@huawei.com> <1509120687-7352-7-git-send-email-gabriele.paoloni@huawei.com> <20171109004604.vkrpyrxbogx7r4td@xps13.dannf> In-Reply-To: <20171109004604.vkrpyrxbogx7r4td@xps13.dannf> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.226.120] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.5A042868.010A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.209, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d752141c583e93bc3854443c98652ab8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dann [...] > > + > > +#define START_WORK 0x01 > > Any reason not to put this in the LPC_ namespace as well? No, not really. We'll make it consistent in the next patchset > > > +/* The minimal nanosecond interval for each query on LPC cycle > status. */ [...] > > + * hisilpc_target_in - trigger a series of lpc cycles to read > required data > > + * from target peripheral. > > + * @pdev: pointer to hisi lpc device > > It's now lpcdev > Thanks, we'll change it. > > + * @para: some parameters used to control the lpc I/O operations [...] > > + * @pio: the target I/O port address. > > @outval & @pio are in the opposite order of the actual function Thanks, we'll change it. > [...] > > + lpcdev->io_host->devpara = NULL; > > + dev_err(dev, "OF: scan hisilpc children got failed(%d)\n", > > + ret); > > nit: Maybe "OF: scanning hisilpc children failed(%d)" ? > Yes, thanks we'll change it. > > + return ret; > > + } > > + > > + dev_info(dev, "hslpc end probing. range[%pa - sz:%pa]\n", > > + &lpcdev->io_host->io_start, > > + &lpcdev->io_host->size); > > + > > + return ret; > > +} > > > -dann From 1583547342886743202@xxx Thu Nov 09 00:47:09 +0000 2017 X-GM-THRID: 1582428117904884132 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread