Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] usbip: use monotonic timestamps
To:     Arnd Bergmann <arnd@arndb.de>,
        Valentina Manea <valentina.manea.m@gmail.com>,
        Shuah Khan <shuah@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Johan Hovold <johan@kernel.org>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Krzysztof Opasiak <k.opasiak@samsung.com>
Message-id: <93e30403-bfe3-9547-122b-bb4955d264be@samsung.com>
Date:   Tue, 07 Nov 2017 12:22:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
        Thunderbird/52.3.0
MIME-version: 1.0
In-reply-to: <20171107104010.2884193-2-arnd@arndb.de>
Content-type: text/plain; charset="utf-8"; format="flowed"
Content-language: en-US
Content-transfer-encoding: 7bit
CMS-TYPE: 102P
References: <20171107104010.2884193-1-arnd@arndb.de>
        <CGME20171107104035epcas5p3b6a2556146de0340d762701451aeb1d2@epcas5p3.samsung.com>
        <20171107104010.2884193-2-arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 11/07/2017 11:39 AM, Arnd Bergmann wrote:
> This gets rid of the deprecated do_gettimeofday() function in usbip.
> The comment above vgadget_get_frame() mentions that it suffers
> from issues with the time jumps due to suspend and settimeofday,
> so I'm changing it to use ktime_get_ts64() to use monotonic times
> that don't have this problem.
> 
> I couldn't tell whether we should use CLOCK_MONOTONIC or
> CLOCK_MONOTONIC_RAW here, the difference being the exact rate
> when correcting for NTP. I picked monotonic time since it doesn't
> change the speed to the existing code and should be better
> synchronized with other machines we talk to.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Looks good to me:
Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com>

-- 
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics

From 1583410561818571461@xxx Tue Nov 07 12:33:05 +0000 2017
X-GM-THRID: 1583410561818571461
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread