Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755914AbYAOSxi (ORCPT ); Tue, 15 Jan 2008 13:53:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751589AbYAOSxb (ORCPT ); Tue, 15 Jan 2008 13:53:31 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:39638 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbYAOSxa (ORCPT ); Tue, 15 Jan 2008 13:53:30 -0500 Date: Tue, 15 Jan 2008 10:52:39 -0800 (PST) From: Linus Torvalds To: Mathieu Desnoyers cc: Russell King , Adrian Bunk , Andrew Morton , Randy Dunlap , phil.el@wanadoo.fr, oprofile-list@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: Fwd: Re: [2.6.24 patch] restore ARMv6 OProfile support In-Reply-To: <20080115173701.GB8375@Krystal> Message-ID: References: <20071228195841.GA3945@flint.arm.linux.org.uk> <20080115104526.GA32067@flint.arm.linux.org.uk> <20080115173701.GB8375@Krystal> User-Agent: Alpine 1.00 (LFD 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 28 On Tue, 15 Jan 2008, Mathieu Desnoyers wrote: > > Well, it goes along the lines of the patch I suggested as a reply to > Adrian, with these differences : > > - I still source the kernel/Kconfig.instrumentation file. > - I put back the missing OPROFILE options directly in arch/arm/Kconfig > > Then end result is the same as your patch, but without the code > duplication. No it's not. Now the config variables may all be there, but the UI for the *menu* system is broken (ie all the ARM profiling config options are now outside the profiling menu). Is that menu really needed? I dunno. But since it exists, it should be correct. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/