Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] selftests: fix compile error for sync
To:     Shuah Khan <shuahkh@osg.samsung.com>
References: <1509876499-18499-1-git-send-email-Lei.Yang@windriver.com>
 <9a23bae8-00ee-eeb6-0b51-16132aab5b1a@osg.samsung.com>
CC:     <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Shuah Khan <shuah@kernel.org>
From:   lei yang <lei.yang@windriver.com>
Message-ID: <c97a29d9-e424-c996-3729-d4d7e0a5bc07@windriver.com>
Date:   Tue, 7 Nov 2017 09:14:00 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <9a23bae8-00ee-eeb6-0b51-16132aab5b1a@osg.samsung.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2017年11月07日 07:35, Shuah Khan wrote:
> On 11/05/2017 03:08 AM, Lei Yang wrote:
>> I got below error message when building sync test:
>>
>> make[1]: Entering directory `tools/testing/selftests/sync'
>> gcc -c sync.c -o tools/testing/selftests/sync/sync.o
>> sync.c:42:29: fatal error: linux/sync_file.h: No such file or directory
>>   #include <linux/sync_file.h>
>>
>> obviously, CFLAGS and LDFLAGS are not used when comipling.
>>
>> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
>> ---
>>   tools/testing/selftests/sync/Makefile | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/sync/Makefile b/tools/testing/selftests/sync/Makefile
>> index 8e04d0a..46cbcc3 100644
>> --- a/tools/testing/selftests/sync/Makefile
>> +++ b/tools/testing/selftests/sync/Makefile
>> @@ -29,9 +29,9 @@ $(TEST_CUSTOM_PROGS): $(TESTS) $(OBJS)
>>   	$(CC) -o $(TEST_CUSTOM_PROGS) $(OBJS) $(TESTS) $(CFLAGS) $(LDFLAGS)
>>   
>>   $(OBJS): $(OUTPUT)/%.o: %.c
>> -	$(CC) -c $^ -o $@
>> +	$(CC) -c $^ -o $@ $(CFLAGS) $(LDFLAGS)
>>   
>>   $(TESTS): $(OUTPUT)/%.o: %.c
>> -	$(CC) -c $^ -o $@
>> +	$(CC) -c $^ -o $@ $(CFLAGS) $(LDFLAGS)
>>   
>>   EXTRA_CLEAN := $(TEST_CUSTOM_PROGS) $(OBJS) $(TESTS)
>>
> How are you building the test? I am not seeing the error on linux-4.14.0-rc8

make -C tools/testing/selftests

Lei


> thanks,
> -- Shuah
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


From 1583361722032610451@xxx Mon Nov 06 23:36:47 +0000 2017
X-GM-THRID: 1583220447462694273
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread