Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] selftests: fix compile error for sync
To:     Lei Yang <Lei.Yang@windriver.com>
References: <1509876499-18499-1-git-send-email-Lei.Yang@windriver.com>
Cc:     linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <shuahkh@osg.samsung.com>,
        Shuah Khan <shuah@kernel.org>
From:   Shuah Khan <shuahkh@osg.samsung.com>
Message-ID: <9a23bae8-00ee-eeb6-0b51-16132aab5b1a@osg.samsung.com>
Date:   Mon, 6 Nov 2017 16:35:21 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1509876499-18499-1-git-send-email-Lei.Yang@windriver.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/05/2017 03:08 AM, Lei Yang wrote:
> I got below error message when building sync test:
> 
> make[1]: Entering directory `tools/testing/selftests/sync'
> gcc -c sync.c -o tools/testing/selftests/sync/sync.o
> sync.c:42:29: fatal error: linux/sync_file.h: No such file or directory
>  #include <linux/sync_file.h>
> 
> obviously, CFLAGS and LDFLAGS are not used when comipling.
> 
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
>  tools/testing/selftests/sync/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/sync/Makefile b/tools/testing/selftests/sync/Makefile
> index 8e04d0a..46cbcc3 100644
> --- a/tools/testing/selftests/sync/Makefile
> +++ b/tools/testing/selftests/sync/Makefile
> @@ -29,9 +29,9 @@ $(TEST_CUSTOM_PROGS): $(TESTS) $(OBJS)
>  	$(CC) -o $(TEST_CUSTOM_PROGS) $(OBJS) $(TESTS) $(CFLAGS) $(LDFLAGS)
>  
>  $(OBJS): $(OUTPUT)/%.o: %.c
> -	$(CC) -c $^ -o $@
> +	$(CC) -c $^ -o $@ $(CFLAGS) $(LDFLAGS)
>  
>  $(TESTS): $(OUTPUT)/%.o: %.c
> -	$(CC) -c $^ -o $@
> +	$(CC) -c $^ -o $@ $(CFLAGS) $(LDFLAGS)
>  
>  EXTRA_CLEAN := $(TEST_CUSTOM_PROGS) $(OBJS) $(TESTS)
> 

How are you building the test? I am not seeing the error on linux-4.14.0-rc8

thanks,
-- Shuah

From 1583220447462694273@xxx Sun Nov 05 10:11:17 +0000 2017
X-GM-THRID: 1583220447462694273
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread