Received: by 10.223.164.221 with SMTP id h29csp802460wrb; Fri, 13 Oct 2017 06:35:09 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCpfWNcA8owPB2irbycQGwe24zN2LXFtSo03WeCH7e82Q4f/dIXdvqbIotd+VqaBZdC8k4b X-Received: by 10.98.190.16 with SMTP id l16mr1430156pff.124.1507901709347; Fri, 13 Oct 2017 06:35:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507901709; cv=none; d=google.com; s=arc-20160816; b=P2cdEEyDd+zLr1DDo/g+6OTXUr5ALG0tFQNUHxXpOpLHB+RLUieo2MsLFLSKG95PNs XFwDsZhCx1zkSfJwOxOJHrnxHmnLvIBJHhev0n4Akoh70uImIxHMG8m7ZB/U9gK5ZTXf ppMF94ncX7qQNTYEESZi1rJa2Iw4kCWqhaavfWvvlARTSzJfFgY0I0pbbSz5xl1lypkz IiVlOd59LcS2QpVgGDpQygmVYDDMIP2KM/tSIFnMP4H2OePN5Zs30AM6RFmV7mfsvXcH YF/LVXFcXoTEicxArhYehP5FvjzV/zDGhGkrhmC0AxcMInUjHHabjYRAQ4MyVl+K2dps LpYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=FhMtaKaJ6XfiWcl+TLlNJKDWlMNezmD4+QqapNPgTAk=; b=nJOfhVBrPPbb5ZPfEcl/uKohD9Yg0iRqv1RRV9BXewfvBZcmWSlg+RnWdYVGaO6ApA RTawExqKDYbaSHEesckhTQLabOpjQwwq4jK/txPsqf0IcA+Or5x+N36ULodi8uGmcGLd BTFQoPUtF9FDuNTj6Zssdh4XQDSK2gJmGiionzEiAWjA9QDAqshpeyXkOe+VjSTaqncX ZpIj62rmLlM/+FaKV2kHvXh/riAndPD37OBUGONQAFdSMZLuNbrZJ4aSKTGOgc5yIZ3e 8II/310mwT6STA99GAWX8K/iqQF92e6gR5J0do1UfeFkK7pRkvCPGTuGqC5OEYRTs1QM n36A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n89si580363pfa.592.2017.10.13.06.34.55; Fri, 13 Oct 2017 06:35:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758089AbdJMNe3 (ORCPT + 99 others); Fri, 13 Oct 2017 09:34:29 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:8039 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753380AbdJMNe2 (ORCPT ); Fri, 13 Oct 2017 09:34:28 -0400 Received: from 172.30.72.59 (EHLO DGGEMS409-HUB.china.huawei.com) ([172.30.72.59]) by dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued) with ESMTP id DJB53936; Fri, 13 Oct 2017 21:34:25 +0800 (CST) Received: from huawei.com (10.107.193.250) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.301.0; Fri, 13 Oct 2017 21:31:44 +0800 From: Yunlong Song To: , , , , CC: , , , , Subject: [PATCH v2] f2fs: add bug_on when f2fs_gc even fails to get one victim Date: Fri, 13 Oct 2017 21:31:40 +0800 Message-ID: <1507901500-162168-1-git-send-email-yunlong.song@huawei.com> X-Mailer: git-send-email 1.8.5.2 In-Reply-To: <1507729864-118702-1-git-send-email-yunlong.song@huawei.com> References: <1507729864-118702-1-git-send-email-yunlong.song@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.107.193.250] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.59E0C0E1.00CE,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: e33902642d2fa13b9cfc6a8cd13fa05d Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This can help us to debug on some corner case. Signed-off-by: Yunlong Song Signed-off-by: Chao Yu --- fs/f2fs/gc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 197ebf4..2b03202 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -986,6 +986,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, .ilist = LIST_HEAD_INIT(gc_list.ilist), .iroot = RADIX_TREE_INIT(GFP_NOFS), }; + bool need_fggc = false; trace_f2fs_gc_begin(sbi->sb, sync, background, get_pages(sbi, F2FS_DIRTY_NODES), @@ -1018,8 +1019,10 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, if (ret) goto stop; } - if (has_not_enough_free_secs(sbi, 0, 0)) + if (has_not_enough_free_secs(sbi, 0, 0)) { gc_type = FG_GC; + need_fggc = true; + } } /* f2fs_balance_fs doesn't need to do BG_GC in critical path. */ @@ -1028,6 +1031,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, goto stop; } if (!__get_victim(sbi, &segno, gc_type)) { + f2fs_bug_on(sbi, !total_freed && need_fggc); ret = -ENODATA; goto stop; } -- 1.8.5.2 From 1581145170122603919@xxx Fri Oct 13 12:25:39 +0000 2017 X-GM-THRID: 1580969854381445046 X-Gmail-Labels: Inbox,Category Forums