Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 7 Nov 2017 12:39:58 -0500 (EST)
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Colin King <colin.king@canonical.com>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-usb@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: host: fix incorrect updating of offset
In-Reply-To: <20171107164504.5920-1-colin.king@canonical.com>
Message-ID: <Pine.LNX.4.44L0.1711071239370.1395-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 7 Nov 2017, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable temp is incorrectly being updated, instead it should
> be offset otherwise the loop just reads the same capability value
> and loops forever.  Thanks to Alan Stern for pointing out the
> correct fix to my original fix.  Fix also cleans up clang warning:
> 
> drivers/usb/host/ehci-dbg.c:840:4: warning: Value stored to 'temp'
> is never read
> 
> Fixes: d49d43174400 ("USB: misc ehci updates")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/usb/host/ehci-dbg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
> index 7fb21d01b3d0..3bd0b2273171 100644
> --- a/drivers/usb/host/ehci-dbg.c
> +++ b/drivers/usb/host/ehci-dbg.c
> @@ -838,7 +838,7 @@ static ssize_t fill_registers_buffer(struct debug_buffer *buf)
>  			default:		/* unknown */
>  				break;
>  			}
> -			temp = (cap >> 8) & 0xff;
> +			offset = (cap >> 8) & 0xff;
>  		}
>  	}
>  #endif

Acked-by: Alan Stern <stern@rowland.harvard.edu>


From 1583460291363647083@xxx Wed Nov 08 01:43:30 +0000 2017
X-GM-THRID: 1583460291363647083
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread