Received: by 10.223.164.202 with SMTP id h10csp394225wrb; Wed, 8 Nov 2017 19:03:53 -0800 (PST) X-Google-Smtp-Source: ABhQp+RkKpQqYpSLHtfPBF5U8dvmiapfa/mU6RjjCFgrjPjMG8mts5DFOC62NXMXcg4HKhaBiiuY X-Received: by 10.84.135.101 with SMTP id 92mr2421230pli.180.1510196633067; Wed, 08 Nov 2017 19:03:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510196633; cv=none; d=google.com; s=arc-20160816; b=DFG/nSJeFVDEY5CIjtdNqqimQROJplCIxTyrS4JWmgUQ5saYoTe1fXwca1VQ+UI9qa dBLzZTFG+sLfCfdbLVgCNC5aG0zG1noFlG6LWjesK373N5Xl6pDmcb3b85MghoxkDlK/ Lgmx+sVkc22iGfJsKnPbWSN3QX5geoJHpe7BVhXvaXmHfkAhCKsOqdzaOwV/QJdj1m3Y 1dL8BbKD9ejuQ/7WdjrAZVqLv/45VsRpXcLzto0p7x2XMPYAffdM4pWxxP+qNp3vV5E7 zqNfNPWl/4UlzkoO4n4vrz4QOv8apw3paST+N6gPKt2TOZf+iBPER7ami5gNoHoBqxFK HHoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=oQk6SQDNi5Br1y3Nsw2MxUc5TrfrUSH+ICQBpGtoVFs=; b=iSmjVrCKQ6MTDDjxrzbmxZJEkJ1fsxHtmyVNQ8L2/Ph+bJhBhk09jzBh/7jswGuOUy 9SQbDt7Mu6X6AVvYqPtxrbbjnZwaJmIz9Y70veg8br3TZB18C1gqpBlpKRdLJuMVWD/Z 9oM7XSsYJArZcBnxHfsUI/+DgdBC7O9SXR91l95FYVzOITGDyBaDXeIuE9vdAnIDI2H0 PB+OnB5RDmWeoXeCDwwMdKH8mPwbGkXRws4oY1gTHcO3R4zMt3lFKuIgXpaOtRXcRPcw BipQEy4CbR7qpxOvYuJWhZyyJrBETMeFv8vj+3lCrMRorWRz/Gjwk8DUoffAX4iKKDSq 5BXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b96si5137340pli.387.2017.11.08.19.03.40; Wed, 08 Nov 2017 19:03:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752499AbdKIDC6 (ORCPT + 82 others); Wed, 8 Nov 2017 22:02:58 -0500 Received: from gateway22.websitewelcome.com ([192.185.46.142]:26912 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231AbdKIDCv (ORCPT ); Wed, 8 Nov 2017 22:02:51 -0500 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway22.websitewelcome.com (Postfix) with ESMTP id DF5614C7F for ; Wed, 8 Nov 2017 21:02:50 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id Cd7CezQ98c72gCd7CewVZb; Wed, 08 Nov 2017 21:02:50 -0600 Received: from [189.175.248.21] (port=34370 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1eCd7C-001Mue-Ix; Wed, 08 Nov 2017 21:02:50 -0600 Date: Wed, 8 Nov 2017 21:02:50 -0600 From: "Gustavo A. R. Silva" To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] Input: sidewinder - mark expected switch fall-throughs Message-ID: <20171109030250.GA13692@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.175.248.21 X-Source-L: No X-Exim-ID: 1eCd7C-001Mue-Ix X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.175.248.21]:34370 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 3 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114763 Addresses-Coverity-ID: 114764 Addresses-Coverity-ID: 114765 Addresses-Coverity-ID: 114766 Signed-off-by: Gustavo A. R. Silva --- drivers/input/joystick/sidewinder.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/input/joystick/sidewinder.c b/drivers/input/joystick/sidewinder.c index 4a95b22..5e602a6 100644 --- a/drivers/input/joystick/sidewinder.c +++ b/drivers/input/joystick/sidewinder.c @@ -672,16 +672,16 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv) switch (i * m) { case 60: - sw->number++; + sw->number++; /* fall through */ case 45: /* Ambiguous packet length */ if (j <= 40) { /* ID length less or eq 40 -> FSP */ case 43: sw->type = SW_ID_FSP; break; } - sw->number++; + sw->number++; /* fall through */ case 30: - sw->number++; + sw->number++; /* fall through */ case 15: sw->type = SW_ID_GP; break; @@ -697,9 +697,9 @@ static int sw_connect(struct gameport *gameport, struct gameport_driver *drv) sw->type = SW_ID_PP; break; case 66: - sw->bits = 3; + sw->bits = 3; /* fall through */ case 198: - sw->length = 22; + sw->length = 22; /* fall through */ case 64: sw->type = SW_ID_3DP; if (j == 160) -- 2.7.4 From 1591057128276989430@xxx Tue Jan 30 22:11:59 +0000 2018 X-GM-THRID: 1584673843970868418 X-Gmail-Labels: Inbox,Category Forums,Downloaded_2018-01