Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] backlight: ili922x: remove redundant variable len
To:     Colin King <colin.king@canonical.com>,
        Lee Jones <lee.jones@linaro.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20171105115326.5276-1-colin.king@canonical.com>
From:   Daniel Thompson <daniel.thompson@linaro.org>
Message-ID: <b0b6c0ed-6e9f-3b91-c31d-2f0d2d861e3f@linaro.org>
Date:   Mon, 6 Nov 2017 11:36:01 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20171105115326.5276-1-colin.king@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 05/11/17 11:53, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable len is assigned but never read, therefore it is redundant
> and can be removed. Cleans up clang warning:
> 
> drivers/video/backlight/ili922x.c:276:2: warning: Value stored to 'len'
> is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Daniel Thompson <daniel.thompson@linaro.org>

> ---
>   drivers/video/backlight/ili922x.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c
> index a9e9cef..2b6c6aa 100644
> --- a/drivers/video/backlight/ili922x.c
> +++ b/drivers/video/backlight/ili922x.c
> @@ -251,7 +251,7 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value)
>   	struct spi_transfer xfer_regindex, xfer_regvalue;
>   	unsigned char tbuf[CMD_BUFSIZE];
>   	unsigned char rbuf[CMD_BUFSIZE];
> -	int ret, len = 0;
> +	int ret;
>   
>   	memset(&xfer_regindex, 0, sizeof(struct spi_transfer));
>   	memset(&xfer_regvalue, 0, sizeof(struct spi_transfer));
> @@ -273,7 +273,6 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value)
>   	ret = spi_sync(spi, &msg);
>   
>   	spi_message_init(&msg);
> -	len = 0;
>   	tbuf[0] = set_tx_byte(START_BYTE(ili922x_id, START_RS_REG,
>   					 START_RW_WRITE));
>   	tbuf[1] = set_tx_byte((value & 0xFF00) >> 8);
> 


From 1583247710714476803@xxx Sun Nov 05 17:24:38 +0000 2017
X-GM-THRID: 1583226962883469837
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread