Received: by 10.223.164.221 with SMTP id h29csp155484wrb; Tue, 31 Oct 2017 11:37:06 -0700 (PDT) X-Google-Smtp-Source: ABhQp+SesF7+nFbPcA1wGFT/7XYcjcxtGOnMhr/nxZ+WGtuGUVpfm8GodfTuWoLip3O1JJKqIlel X-Received: by 10.101.88.14 with SMTP id g14mr693846pgr.412.1509475025883; Tue, 31 Oct 2017 11:37:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509475025; cv=none; d=google.com; s=arc-20160816; b=s/TbntA2INOCqON/rSMx/1bYqddfyu9WfQiB+Q3o11ALUmrq+ymkFQa77jIFR2rlmi SJVHBVc7VcOzWO3nCDeKMPFEx9osfghoQ7G1zPFexqCXcyoy9Tv5JtSyDjERm9tVXgtv 2lstMEe6eDu+pN7/y3LQkPLdTnWWZDqiHRDk8Uwf0aW0djs78t6V+QvdQxUhwmJ9/Aml 3jOVsxNcpnmVqasRMbhAw5jiFa3ExBuXXA4nnH4/UU4ugf/Z05bOOxEd1cM5dgrY2vpY 4+H4F/Xlb6uVKsPSZ5KzBnUFMUPSNgHfgL1IKn7t2CoZckFLgdUch02Q0v6EGlBrZE8s kjiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:spamdiagnosticmetadata:spamdiagnosticoutput :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=NcY6hDYjKX04fiGYzHWNMLPctP2VuhMBFu05GP+SgBI=; b=GfdLebUT0pHhiNUYdQQrKAEXJev55tv2kQ3vxcIIRxK6l3TFtopmhFpZ6ARicwgzQN RCIzPWxhOTXlv1+d4hTs46kgLZpHDdCdgc17AlZObI/ZD+rx4vPxwv+Uzhg48faqnKhu 7q86LfZVWd7X3ril6SAEdUHuk4a7iXIPdSVSecWyDzLkLBjV7Gw8wMCMV8AL3vjai4Zx iexPFagAd77Wu56lwsPnW972Oxz6r66UB+PcrTIg04s8iyT5YGfl0YoZWdvsfNO7I4sb 2NqOCs6uJLtyqLrynPBSJ6M6Y2aC28Sh1rd1FkatMA/JWdX9l65Ha40g4ESaH3WmLWrf 9Ctw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@CAVIUMNETWORKS.onmicrosoft.com header.s=selector1-cavium-com header.b=M+cozZtq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v17si2082775pge.502.2017.10.31.11.36.52; Tue, 31 Oct 2017 11:37:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@CAVIUMNETWORKS.onmicrosoft.com header.s=selector1-cavium-com header.b=M+cozZtq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932618AbdJaSgM (ORCPT + 99 others); Tue, 31 Oct 2017 14:36:12 -0400 Received: from mail-by2nam03on0084.outbound.protection.outlook.com ([104.47.42.84]:38542 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932423AbdJaSgJ (ORCPT ); Tue, 31 Oct 2017 14:36:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NcY6hDYjKX04fiGYzHWNMLPctP2VuhMBFu05GP+SgBI=; b=M+cozZtqsWrRjDmCfIZrfcixkmApOw/enLxdrgAEEXJOo3cbetixu6lKYmbmIrI/fcLtwGwKmriYvGWT9UNkWBjnd26hlwxi7E3Px0JOVWwwiIIUzx8d4BEfTNIc8T4b4Ol9GyHFiM3Cg6LX1fYovZHwh0y5Q135PiHtyuqiFvk= Received: from MWHPR07MB3455.namprd07.prod.outlook.com (10.164.192.18) by MWHPR07MB3456.namprd07.prod.outlook.com (10.164.192.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Tue, 31 Oct 2017 18:36:07 +0000 Received: from MWHPR07MB3455.namprd07.prod.outlook.com ([10.164.192.18]) by MWHPR07MB3455.namprd07.prod.outlook.com ([10.164.192.18]) with mapi id 15.20.0178.014; Tue, 31 Oct 2017 18:36:07 +0000 From: "Madhani, Himanshu" To: Kees Cook CC: Bart Van Assche , "martin.petersen@oracle.com" , "jejb@linux.vnet.ibm.com" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , Dept-Eng QLA2xxx Upstream Subject: Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Topic: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Index: AQHTTXkYGo0ktCcFY0ucpeQkciWZRaL+JN91gAAlXQCAAAJvgIAAASsAgAADVgCAAAIagA== Date: Tue, 31 Oct 2017 18:36:07 +0000 Message-ID: <4AF4B68F-9343-437E-ADA7-1675E32998B9@cavium.com> References: <20171025100737.GA145097@beast> <16733DFA-7339-4F77-9125-E8845C4FCD6F@cavium.com> <1509473546.12927.5.camel@wdc.com> <3CE2B08B-07F4-411D-B87A-18F586F5534C@cavium.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Himanshu.Madhani@cavium.com; x-originating-ip: [173.186.134.106] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR07MB3456;6:/Bc9UYU0w1f5lv3IE73ETxCXTPzZMKIoHsLcFpC22wuCj6zwV0NdKT3PXiBfTod3QksZI5gvkbRuDt2Nqcv+JiL54y6j6Ze6pY4nRAd3sofaHlrY+EH/nN0+25sTHfXePz4LrWxo9WpofORV/kGAkP4TegcmWYRrdvsY19uQXEgrwDbyxDfMlXXqQc4uZmkKzUlKXgkiMe9/BYNyfT9aNa8e/UGNxHOYXfcVAu7knXXN13Hz5TJom4/lkuvSZOC7PkYtw57+BaudRtAFTBJu2+IFsI6fv4Ven0ceZ3Uw2tvR4MXWjw9U4741fOOdw/jYTriyLM83LJKbXMA7OrF8IN/8+ReYP3yrXzkLjNh5ag4=;5:uJzbOAH4mDpF1mHgM6/9XbupbuzNK5uTJHxifnP4VWCzc496AUf159839JCB4ql5sTQMzowudvJOktfSSSbizbkNzaFClG01+qxfOFuY5NQ1Hu4L7ahjAFUY2cjqu8pioZUWLOSoC+zMlyY9exAJsdlmPRB3hU1wyETRdOQNh+k=;24:3lWnCaCniCYci5LAT3jHIvZFCwAA5K1QhpEsMLRA2qQsUnKToOxY4ccEZUZs1L/540iDn7e279QVCmKpWVBELYEmKh5dTLs2/U+ZqwXuvAA=;7:Ng6HhsyztyG5lHRJQb5+jN6LX9nmrmeGWddCci9wyEWfPLnfL62eteWVdYKaPoQ292dAOKSeaaIxoD0xU+6F0VnGE+NwUDPTfCOD/niS7EeC3/M/ipyVWZHxB0/EUYBEOnzDc47XHkCqlH8Evy9VZL8z2JkZNCQjPuaGyZEO6Vp4ccN5nHHOjL10g8Q+4b+XRx2Q9Ec/CITCiVsXGtqTgkk8+3xY2q+bhTq6kXtyt6DgZcPVW+eogroq19qwnD9N x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: d04409b3-61c6-49a5-2a0a-08d5208e3fec x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(2017052603199);SRVR:MWHPR07MB3456; x-ms-traffictypediagnostic: MWHPR07MB3456: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(3231020)(10201501046)(93006095)(93001095)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123558100)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR07MB3456;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR07MB3456; x-forefront-prvs: 04772EA191 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(199003)(189002)(24454002)(25786009)(68736007)(2900100001)(6916009)(81156014)(3846002)(97736004)(3280700002)(2950100002)(36756003)(8936002)(3660700001)(8676002)(93886005)(81166006)(6116002)(102836003)(54356999)(50986999)(7736002)(305945005)(106356001)(105586002)(66066001)(189998001)(76176999)(53546010)(5660300001)(2906002)(478600001)(4326008)(82746002)(54906003)(6506006)(86362001)(229853002)(33656002)(77096006)(6486002)(6436002)(83716003)(101416001)(72206003)(6246003)(14454004)(53936002)(316002)(107886003)(99286003)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB3456;H:MWHPR07MB3455.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <434A67F52B6693409FCA4E3A30255C59@namprd07.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: d04409b3-61c6-49a5-2a0a-08d5208e3fec X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2017 18:36:07.0961 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3456 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kees,=20 > On Oct 31, 2017, at 11:28 AM, Kees Cook wrote: >=20 > How very strange. I don't see any code change with this patch. Even > the passed arguments are the same; it's only enforcing the types now. > And the system is fine with only this patch reverted? Yes. Agree patch looks okay, but with the patch built into driver I see system going into infinite loop of trying to bring link up and lock up=20 after few minutes, Only way to recover is hard reboot.=20 I reverted this patch after system boot up and rebuild qla2xxx and able to load driver. Thanks, - Himanshu From 1582799026870178426@xxx Tue Oct 31 18:32:59 +0000 2017 X-GM-THRID: 1582223819691870901 X-Gmail-Labels: Inbox,Category Forums