Received: by 10.223.164.202 with SMTP id h10csp1048723wrb; Tue, 7 Nov 2017 20:37:47 -0800 (PST) X-Google-Smtp-Source: ABhQp+RXb0T5ylsSHnd596FmXSUeAjXL8FpgnHPOuh8W5YZJ8AKIszgvvFA5PkFHM+WKFx6niIN0 X-Received: by 10.99.182.66 with SMTP id v2mr1052712pgt.325.1510115867480; Tue, 07 Nov 2017 20:37:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510115867; cv=none; d=google.com; s=arc-20160816; b=eR7BkFFO8yIAUNzzKPoh1Mlh4EzOnsl8LT6GM+RgQ0ho/HxqHoVt3bXVN/Ib36swys 3zChAdf7WJB0+kzHydZH0L0OyK/oUuKOvPB5qHgyKHyzVU0vzBVblex/rVG71lMr+LDC k8eVptbxyKAWdfoz+6IPrqDvYJ1YkSesekmcVM1AeMOV0KsyKSCYuyZ+yjh6/LuoRRul 3CEK9iLQhTP5AMqbHELP9CI5stIO4Df3YNNLJCl5KNGG1aqpb4y0r2AG0PdUOOfzdqnF jkwy6fJMitCT49ld9BlDd1drw59o4li+wKYmWne0HY0CRjBVB04vYxbd7Ou/+aiF5nKc tgVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=USctw3G6vZTEBSDAdw/ogvTTraUzafQ0nLRPiCbK7pc=; b=mJgurYskaPw00++/dedDBFJB06GCp21EX2+xvp3XaHOe3kC4BKYcUfiU0JrqK5Aohs WCktQxXSTymINW/V3sTi51aVgW0JavC5MRX4HBrnFT/CgPpWOheT4W8raQW/NVXvVIIz 5+4bMQMzbDvFKSXPHsar7HJc2i0uj4DnJN75K8IShaGiq3vXYUmUVu2vzpQL9Mt9ciaC FdIZXjS1fSPaf/Y4JyBg6+u25upWx333dBaSjbClijs7omrsvQLjvgDvgXtR+6vQKdJU 55MAXMdruGQl4mxeC2ZOIAuE4mokBfqKO+OIQq9lg8PiTYXapc5WtjM6dcg3CIiK4q7S tiIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3si2878333plm.311.2017.11.07.20.37.34; Tue, 07 Nov 2017 20:37:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752256AbdKHEbL (ORCPT + 91 others); Tue, 7 Nov 2017 23:31:11 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:60301 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbdKHEbK (ORCPT ); Tue, 7 Nov 2017 23:31:10 -0500 X-Greylist: delayed 575 seconds by postgrey-1.27 at vger.kernel.org; Tue, 07 Nov 2017 23:31:10 EST Received: from linux-iscsi.org (localhost [127.0.0.1]) by linux-iscsi.org (Postfix) with ESMTP id 74FF340003; Wed, 8 Nov 2017 04:31:54 +0000 (UTC) From: "Nicholas A. Bellinger" To: target-devel Cc: linux-scsi , lkml , Nicholas Bellinger Subject: [PATCH 0/6] target fixes for v4.15-rc1 Date: Wed, 8 Nov 2017 04:31:46 +0000 Message-Id: <1510115512-15617-1-git-send-email-nab@linux-iscsi.org> X-Mailer: git-send-email 1.7.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicholas Bellinger Hi all, Here are the outstanding target bugfixes in queue for v4.15-rc1 code. Patch #1 addresses a long standing bug wrt to QUEUE_FULL and SCSI task attribute handling, that results in SCSI task related counters getting updated multiple times during QUEUE_FULL. It primarly effects hosts using ORDERED tasks, which depend upon these counters to know when to delay incoming tasks. Patch #2 is for a recent v4.11+ regression, which during ABORT of COMPARE_AND_WRITE can result in se_device->cam_sem getting leaked due to se_cmd->transport_complete_callback() being skipped. Patch #3 addresses a possible end-less loop during QUEUE_FULL + TFO->write_pending() failure, allowing se_cmd quiese to properly complete the outstanding descriptor when requested. Patch #4 addresses a use-after-tree that was hit in the field, involving pre-backend execution se_cmd exceptions + subsequent ABORT_TASK for a matching tag. Patch #5 + #6 address a iscsi-target TMR related memory and se_cmd->cmd_kref reference leaks respectively. We've been testing #4, #5, and #6 internally on v4.1.y stable code, and have not run into additional regressions. The rest are straight-forward. Please review. --nab Nicholas Bellinger (6): target: Fix QUEUE_FULL + SCSI task attribute handling target: Fix caw_sem leak in transport_generic_request_failure target: Fix quiese during transport_write_pending_qf endless loop target: Avoid early CMD_T_PRE_EXECUTE failures during ABORT_TASK iscsi-target: Make TASK_REASSIGN use proper se_cmd->cmd_kref iscsi-target: Fix non-immediate TMR reference leak drivers/target/iscsi/iscsi_target.c | 30 ++++++++++++++---------------- drivers/target/target_core_tmr.c | 9 +++++++++ drivers/target/target_core_transport.c | 26 +++++++++++++++++++++++--- include/target/target_core_base.h | 1 + 4 files changed, 47 insertions(+), 19 deletions(-) -- 1.9.1 From 1583433762486917608@xxx Tue Nov 07 18:41:51 +0000 2017 X-GM-THRID: 1583134391207042419 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread