Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] selftests: add "PASS" status in log for mqueue
To:     Lei Yang <Lei.Yang@windriver.com>
References: <1509873720-618-1-git-send-email-Lei.Yang@windriver.com>
Cc:     linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <shuahkh@osg.samsung.com>,
        Shuah Khan <shuah@kernel.org>
From:   Shuah Khan <shuahkh@osg.samsung.com>
Message-ID: <114b5740-56d3-5b12-8333-5b142505a028@osg.samsung.com>
Date:   Mon, 6 Nov 2017 16:37:17 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1509873720-618-1-git-send-email-Lei.Yang@windriver.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/05/2017 02:22 AM, Lei Yang wrote:
> It prints 'FAIL' status when test failed, but not print
> 'PASS' when test passed.
> 
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
>  tools/testing/selftests/mqueue/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/mqueue/Makefile b/tools/testing/selftests/mqueue/Makefile
> index 0f5e347..437b048 100644
> --- a/tools/testing/selftests/mqueue/Makefile
> +++ b/tools/testing/selftests/mqueue/Makefile
> @@ -5,12 +5,12 @@ TEST_GEN_PROGS := mq_open_tests mq_perf_tests
>  include ../lib.mk
>  
>  override define RUN_TESTS
> -	$(OUTPUT)/mq_open_tests /test1 || echo "selftests: mq_open_tests [FAIL]"
> -	$(OUTPUT)//mq_perf_tests || echo "selftests: mq_perf_tests [FAIL]"
> +	$(OUTPUT)/mq_open_tests /test1 && echo "selftests: mq_open_tests [PASS]" || echo "selftests: mq_open_tests [FAIL]"
> +	$(OUTPUT)/mq_perf_tests && echo "selftests: mq_perf_tests [PASS]" || echo "selftests: mq_perf_tests [FAIL]"
>  endef
>  
>  override define EMIT_TESTS
> -	echo "./mq_open_tests /test1 || echo \"selftests: mq_open_tests [FAIL]\""
> -	echo "./mq_perf_tests || echo \"selftests: mq_perf_tests [FAIL]\""
> +	echo "./mq_open_tests /test1 && echo \"selftests: mq_open_tests [PASS]\" || echo \"selftests: mq_open_tests [FAIL]\""
> +	echo "./mq_perf_tests && echo \"selftests: mq_perf_tests [PASS]\" || echo \"selftests: mq_perf_tests [FAIL]\""
>  endef
>  
> 
Thanks for the patch. I plan to get this into 4.15-rc1

-- Shuah

From 1583217466042018033@xxx Sun Nov 05 09:23:54 +0000 2017
X-GM-THRID: 1583217466042018033
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread