Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To:     netdev@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: [PATCH net-next 5/6] net: dsa: return after vlan prepare phase
Date:   Wed,  8 Nov 2017 12:19:16 -0500
Message-Id: <20171108171917.5965-6-vivien.didelot@savoirfairelinux.com>
In-Reply-To: <20171108171917.5965-1-vivien.didelot@savoirfairelinux.com>
References: <20171108171917.5965-1-vivien.didelot@savoirfairelinux.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

The current code does not return after successfully preparing the VLAN
addition on every ports member of a it. Fix this.

Fixes: 1ca4aa9cd4cc ("net: dsa: check VLAN capability of every switch")
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
 net/dsa/switch.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/dsa/switch.c b/net/dsa/switch.c
index 233ce23b6abb..0ed60456b669 100644
--- a/net/dsa/switch.c
+++ b/net/dsa/switch.c
@@ -200,6 +200,8 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds,
 			if (err)
 				return err;
 		}
+
+		return 0;
 	}
 
 	for_each_set_bit(port, members, ds->num_ports)
-- 
2.15.0


From 1584092971509907960@xxx Wed Nov 15 01:19:41 +0000 2017
X-GM-THRID: 1584088865180666628
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread