Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] powerpc/powernv: Fix IMC_MAX_PMU macro
To:     Michael Ellerman <mpe@ellerman.id.au>,
        Anju T Sudhakar <anju@linux.vnet.ibm.com>
Cc:     linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <1510229426-5547-1-git-send-email-anju@linux.vnet.ibm.com>
 <877euzp3mo.fsf@concordia.ellerman.id.au>
From:   Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Date:   Fri, 10 Nov 2017 06:32:41 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <877euzp3mo.fsf@concordia.ellerman.id.au>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Message-Id: <6429f614-ab35-3c7f-6bfd-1f9f59545bbb@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Friday 10 November 2017 02:32 AM, Michael Ellerman wrote:
> Anju T Sudhakar <anju@linux.vnet.ibm.com> writes:
>
>> IMC_MAX_PMU is used for static storage (per_nest_pmu_arr) which holds
>> nest pmu information. Current value for the macro is 32 based on
>> the initial number of nest pmu units supported by the nest microcode.
>> Currently 29 nest units are enabled based on the system configuration.
>> But going forward, microcode could support more nest units (max of 64
>> nest units). Hence fix the value for the macro.
> There should be no reason to have a hard coded limit.
>
> We should just fix the code to dynamically size the array based on
> what's found in the device tree.

Yes. My bad. Device tree handling part is done in the
platform/powernv side and this data (total number of nest pmus)
can be extended from there. Will work on it.

Thanks for review comments.
Maddy

>
> cheers
>
>> Fixes:8f95faaac56c1 ('powerpc/powernv: Detect and create IMC device')
>> Signed-off-by: Anju T Sudhakar <anju@linux.vnet.ibm.com>
>> ---
>>   arch/powerpc/include/asm/imc-pmu.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/include/asm/imc-pmu.h b/arch/powerpc/include/asm/imc-pmu.h
>> index 7f74c28..f9f0f2e 100644
>> --- a/arch/powerpc/include/asm/imc-pmu.h
>> +++ b/arch/powerpc/include/asm/imc-pmu.h
>> @@ -23,7 +23,7 @@
>>   /*
>>    * For static allocation of some of the structures.
>>    */
>> -#define IMC_MAX_PMUS			32
>> +#define IMC_MAX_PMUS			64
>>   
>>   /*
>>    * Compatibility macros for IMC devices
>> -- 
>> 2.7.4


From 1583623854881687927@xxx Thu Nov 09 21:03:17 +0000 2017
X-GM-THRID: 1583590402295806271
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread