Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V2] kthread: zero the kthread data structure
To:     Shaohua Li <shli@fb.com>, LKML <linux-kernel@vger.kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>, Tejun Heo <tj@kernel.org>,
        Dmitry Vyukov <dvyukov@google.com>
References: <e00c78e6161ef7759a7e5f6abd2db84b9bcc8cf4.1510081552.git.shli@fb.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <cdd1e91b-941f-728d-6be0-34d4886e8d31@kernel.dk>
Date:   Tue, 7 Nov 2017 12:45:38 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <e00c78e6161ef7759a7e5f6abd2db84b9bcc8cf4.1510081552.git.shli@fb.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/07/2017 12:09 PM, Shaohua Li wrote:
> kthread() could bail out early before we initialize blkcg_css (if the
> kthread is killed very early. Please see xchg() statement in kthread()),
> which confuses free_kthread_struct. Instead of moving the blkcg_css
> initialization early, we simply zero the whole 'self' data structure,
> which doesn't sound much overhead.

Applied, thanks Shaohua.

-- 
Jens Axboe


From 1583463356155294722@xxx Wed Nov 08 02:32:13 +0000 2017
X-GM-THRID: 1583463356155294722
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread