Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Haozhong Zhang <haozhong.zhang@intel.com>
To:     kvm@vger.kernel.org, x86@kernel.org
Cc:     linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        rkrcmar@redhat.com, Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
        Dan Williams <dan.j.williams@intel.com>,
        ivan.d.cuevas.escareno@intel.com, karthik.kumar@intel.com,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Olif Chapman <olif.chapman@oracle.com>,
        Mikulas Patocka <mpatocka@redhat.com>,
        Haozhong Zhang <haozhong.zhang@intel.com>,
        Ingo Molnar <mingo@redhat.com>
Subject: [PATCH v5 2/2] KVM: MMU: consider host cache mode in MMIO page check
Date:   Wed,  8 Nov 2017 15:56:30 +0800
Message-Id: <20171108075630.16991-3-haozhong.zhang@intel.com>
In-Reply-To: <20171108075630.16991-1-haozhong.zhang@intel.com>
References: <20171108075630.16991-1-haozhong.zhang@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Some reserved pages, such as those from NVDIMM DAX devices, are not
for MMIO, and can be mapped with cached memory type for better
performance. However, the above check misconceives those pages as
MMIO.  Because KVM maps MMIO pages with UC memory type, the
performance of guest accesses to those pages would be harmed.
Therefore, we check the host memory type in addition and only treat
UC/UC- pages as MMIO.

Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
Reported-by: Cuevas Escareno, Ivan D <ivan.d.cuevas.escareno@intel.com>
Reported-by: Kumar, Karthik <karthik.kumar@intel.com>
---
 arch/x86/kvm/mmu.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 0b481cc9c725..7715476bc5c9 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -2708,7 +2708,20 @@ static bool mmu_need_write_protect(struct kvm_vcpu *vcpu, gfn_t gfn,
 static bool kvm_is_mmio_pfn(kvm_pfn_t pfn)
 {
 	if (pfn_valid(pfn))
-		return !is_zero_pfn(pfn) && PageReserved(pfn_to_page(pfn));
+		return !is_zero_pfn(pfn) && PageReserved(pfn_to_page(pfn)) &&
+			/*
+			 * Some reserved pages, such as those from
+			 * NVDIMM DAX devices, are not for MMIO, and
+			 * can be mapped with cached memory type for
+			 * better performance. However, the above
+			 * check misconceives those pages as MMIO.
+			 * Because KVM maps MMIO pages with UC memory
+			 * type, the performance of guest accesses to
+			 * those pages would be harmed. Therefore, we
+			 * check the host memory type in addition and
+			 * only treat UC/UC- pages as MMIO.
+			 */
+			(!pat_enabled() || pat_pfn_is_uc_or_uc_minus(pfn));
 
 	return true;
 }
-- 
2.14.1


From 1583468622039692839@xxx Wed Nov 08 03:55:55 +0000 2017
X-GM-THRID: 1583468622039692839
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread