Received: by 10.223.164.197 with SMTP id h5csp46806wrb; Sat, 4 Nov 2017 05:42:31 -0700 (PDT) X-Google-Smtp-Source: ABhQp+QwxWNu2YdZFbeSnlV33oHytQYH22TwnYIveda2fTTUdytB2cMPAZRX8digGJCcckaALjNf X-Received: by 10.84.197.131 with SMTP id n3mr9789599pld.227.1509799351797; Sat, 04 Nov 2017 05:42:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509799351; cv=none; d=google.com; s=arc-20160816; b=MI8fN2HaTAHoL3lJ4lb2KmRXuxzSPc7T0Vk2bbqOJJxJ6Q58/TuYCF3sOlDJuGlYTH xNhS1+kE6jkLj1PItFONyOPvM7dt/TuvDHVe22zWASNrDHQPFs7QLT7gEsuaSIua7yVA 4pH1LS9w1YiNbQAEaBj9E5NhebnIF/YyGdR9bAzuH1hPEk244eE47TudGUUMhiit3cs1 0srH4ekja6e8e1flSNZ7LQLD+k6DXZ9CQk4fGQpBMnzYwWxjAe3WmhOkiaQjajmqnJDn mCcVxlfCmELMNBESEos64LKgSzJ7w29nqwTEQA5ER4FgfgSGPxEDaYviYluOin9/x50y Ye+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter:arc-authentication-results; bh=HvwNr30WrFpe4mrek2itmIy1Ohm+VvyxAChci3HR+kA=; b=Ge+T4OYAXp9AYZEjXF8O9/IzvWnPkyzJEDrHf7yb2dJ1lDy5S4rVTBBxHXi0sLhWLd fg9nPNERY0vzyASMW8W35Dzu5r6ta0IGafGmdGP0xxzRjLj9phcTnPJT1s3dkzyn4oxG fLp7QWW4MZCdpOz/CVK4jvgxzLd6LAhj+bDuA7Vl5a4a4KUu3Qs9WDlQC5T0WpU6646x 7qkQtM/LPR61mlqX4rxAo7d+40sSMGARIhdwXiIxJsS+mVHk0khBn4RVuzW/bde1AWi9 jEuWdMnECs3fWz4rSBKFFEX8Oele4HVm/NK+INyJCyulhl+aCv+TodIPG7oUTpgp8Q4s T4cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@meituan.com header.s=20130113 header.b=aMegcqHL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=meituan.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11si8779421pfh.312.2017.11.04.05.42.18; Sat, 04 Nov 2017 05:42:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@meituan.com header.s=20130113 header.b=aMegcqHL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=meituan.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933181AbdKDMln (ORCPT + 93 others); Sat, 4 Nov 2017 08:41:43 -0400 Received: from mx-fe5-210.meituan.com ([103.37.138.210]:40533 "EHLO mx02.meituan.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932258AbdKDMlm (ORCPT ); Sat, 4 Nov 2017 08:41:42 -0400 Received: from dx-it-mx02.dx.sankuai.com (localhost [127.0.0.1]) by dx-it-mx02.dx.sankuai.com (Postfix) with ESMTP id B0A1A2977E26; Sat, 4 Nov 2017 20:41:32 +0800 (CST) Received: from localhost (localhost [127.0.0.1]) by dx-it-mx02.dx.sankuai.com (Postfix) with ESMTP id 74C3B2977E77; Sat, 4 Nov 2017 20:41:31 +0800 (CST) Received: from mx02.meituan.com ([127.0.0.1]) by localhost (dx-it-mx02.dx.sankuai.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 435Cocco3InY; Sat, 4 Nov 2017 20:41:31 +0800 (CST) Received: from localhost (localhost [127.0.0.1]) by dx-it-mx02.dx.sankuai.com (Postfix) with ESMTP id 1B2AD2977E26; Sat, 4 Nov 2017 20:41:31 +0800 (CST) DKIM-Filter: OpenDKIM Filter v2.9.2 dx-it-mx02.dx.sankuai.com 1B2AD2977E26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meituan.com; s=20130113; t=1509799291; bh=HvwNr30WrFpe4mrek2itmIy1Ohm+VvyxAChci3HR+kA=; h=From:To:Subject:Date:Message-Id; b=aMegcqHLbxJ8pRuhHIx1PHDvd8TFDLIG1McTB6Qmw0ABWqD5NdSthcRW3PSUHJt0t Fr9UUp1z2YbPngxGi9hOGJHLA90D7daItpBBoiFs7UN9UuRuKCuPpZetRyyRlBOIs0 7PBpnxkjC9daMOFLthEybbBeQQ2j7pMHU2joN0c0= X-Virus-Scanned: amavisd-new at dx-it-mx02.dx.sankuai.com Received: from mx02.meituan.com ([127.0.0.1]) by localhost (dx-it-mx02.dx.sankuai.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id czSL0ccd3Vuc; Sat, 4 Nov 2017 20:41:30 +0800 (CST) Received: from localhost.lan (unknown [221.223.164.73]) by dx-it-mx02.dx.sankuai.com (Postfix) with ESMTPA id 556E02970C54; Sat, 4 Nov 2017 20:41:17 +0800 (CST) From: Wang Long To: jack@suse.cz, tj@kernel.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org Cc: axboe@fb.com, nborisov@suse.com, hannes@cmpxchg.org, vdavydov.dev@gmail.com, jlayton@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2] writeback: remove the unused function parameter Date: Fri, 3 Nov 2017 01:04:45 -0400 Message-Id: <1509685485-15278-1-git-send-email-wanglong19@meituan.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The parameter `struct bdi_writeback *wb` is not been used in the function body. so we just remove it. Signed-off-by: Wang Long --- include/linux/backing-dev.h | 2 +- mm/page-writeback.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h index 1662157..186a2e7 100644 --- a/include/linux/backing-dev.h +++ b/include/linux/backing-dev.h @@ -95,7 +95,7 @@ static inline s64 wb_stat_sum(struct bdi_writeback *wb, enum wb_stat_item item) /* * maximal error of a stat counter. */ -static inline unsigned long wb_stat_error(struct bdi_writeback *wb) +static inline unsigned long wb_stat_error(void) { #ifdef CONFIG_SMP return nr_cpu_ids * WB_STAT_BATCH; diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 0b9c5cb..9287466 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1543,7 +1543,7 @@ static inline void wb_dirty_limits(struct dirty_throttle_control *dtc) * actually dirty; with m+n sitting in the percpu * deltas. */ - if (dtc->wb_thresh < 2 * wb_stat_error(wb)) { + if (dtc->wb_thresh < 2 * wb_stat_error()) { wb_reclaimable = wb_stat_sum(wb, WB_RECLAIMABLE); dtc->wb_dirty = wb_reclaimable + wb_stat_sum(wb, WB_WRITEBACK); } else { @@ -1802,7 +1802,7 @@ static void balance_dirty_pages(struct address_space *mapping, * more page. However wb_dirty has accounting errors. So use * the larger and more IO friendly wb_stat_error. */ - if (sdtc->wb_dirty <= wb_stat_error(wb)) + if (sdtc->wb_dirty <= wb_stat_error()) break; if (fatal_signal_pending(current)) -- 1.8.3.1 From 1583135552686898594@xxx Sat Nov 04 11:41:55 +0000 2017 X-GM-THRID: 1583134466679467128 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread