Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net-next 4/5] net: dsa: lan9303: Remove unnecessary
 parentheses
To:     Joe Perches <joe@perches.com>, andrew@lunn.ch,
        vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20171103105553.16859-1-privat@egil-hjelmeland.no>
 <20171103105553.16859-5-privat@egil-hjelmeland.no>
 <1509718281.15520.11.camel@perches.com>
From:   Egil Hjelmeland <privat@egil-hjelmeland.no>
Message-ID: <32ae5cf5-ed19-106c-2625-b53074e00282@egil-hjelmeland.no>
Date:   Fri, 3 Nov 2017 15:35:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1509718281.15520.11.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 03. nov. 2017 15:11, Joe Perches wrote:
> On Fri, 2017-11-03 at 11:55 +0100, Egil Hjelmeland wrote:
>> Remove scripts/checkpatch.pl CHECKs by remove unnecessary parentheses
> []
>> diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
> []
>> @@ -483,7 +483,7 @@ static int lan9303_detect_phy_setup(struct lan9303 *chip)
>>   		return reg;
>>   	}
>>   
>> -	if ((reg != 0) && (reg != 0xffff))
>> +	if (reg != 0 && reg != 0xffff)
>>   		chip->phy_addr_sel_strap = 1;
>>   	else
>>   		chip->phy_addr_sel_strap = 0;
> 
> phy_addr_sel_strap is currently bool.
> 
> If this is to be changed, it should be set
> true or false.
> 
> My preference would be:
> 
> 	chip->phy_addr_sel_strap = (reg != 0 && reg != 0xffff);
> 
> But perhaps its bool type should be converted
> to int as this phy_addr_sel_strap is used as
> int several times.
> 

Hi Joe

I had not noticed that phy_addr_sel_strap is bool. I agree that is
misleading. Your suggestion is perhaps a bit "magic", but on the other
hand the magic is explained well in the comment above.

If there are no disagreements, I can do a v2 with that.

And thanks for teaching me about "git grep"!

Cheers
Egil


From 1583054457516942080@xxx Fri Nov 03 14:12:57 +0000 2017
X-GM-THRID: 1583042314863571680
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread