Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 1/2] selftests: bpf: test_kmod.sh: check if module is
 present in the path before insert
To:     Naresh Kamboju <naresh.kamboju@linaro.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Shuah Khan <shuah@kernel.org>
Cc:     linux-kselftest@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        davem@davemloft.net, alexei.starovoitov@gmail.com,
        netdev@vger.kernel.org, shuah Khan <shuahkh@osg.samsung.com>
References: <1504772342-21878-1-git-send-email-naresh.kamboju@linaro.org>
 <59B10E84.9090801@iogearbox.net>
 <CA+G9fYvioCdeZdWjY1MfQDTwSe9XnpS3xWHFB01jz=SuV6VRDw@mail.gmail.com>
From:   Shuah Khan <shuahkh@osg.samsung.com>
Message-ID: <7ab64eed-9656-b447-ed4b-3daa1246325b@osg.samsung.com>
Date:   Mon, 6 Nov 2017 09:16:46 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CA+G9fYvioCdeZdWjY1MfQDTwSe9XnpS3xWHFB01jz=SuV6VRDw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/06/2017 08:23 AM, Naresh Kamboju wrote:
> On 7 September 2017 at 14:46, Daniel Borkmann <daniel@iogearbox.net> wrote:
>> On 09/07/2017 10:19 AM, naresh.kamboju@linaro.org wrote:
>>>
>>> From: Naresh Kamboju <naresh.kamboju@linaro.org>
>>>
>>> The test script works when kernel source and build module test_bpf.ko
>>> present on the machine. This patch will check if module is present in
>>> the path.
>>>
>>> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>>
>>
>> Looks good, what changed between v1 and v2? Didn't get the cover
>> letter in case there was one. ;)
> 
> No change for 1/2 to v2 1/2. The only change was to v2 2/2.
> 
>>
>> Which tree are you targeting? There are usually a lot of changes
>> in BPF selftests going the usual route via net and net-next tree
>> as we often require to put test cases along the BPF patches. Given
>> the merge window now and given one can regard it as a fix, it's
>> net tree. I'm also ok if Shuah wants to pick it up this window as
>> test_kmod.sh hasn't been changed in quite a while, so no merge
>> conflicts expected.
> 
> I did not see any conflict for this file (selftests/bpf/test_kmod.sh)
> 
>>
>> Anyway, for the patch:
>>
>> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
>>
>> Thanks!
> 
> Thank you.
> 
> - Naresh

Hi Naresh,

Please rebase and resend both patches with Daniel's Acks.

thanks,
-- Shuah

From 1583330729751332763@xxx Mon Nov 06 15:24:11 +0000 2017
X-GM-THRID: 1577868220909329273
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread