Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 7 Nov 2017 00:56:48 +0800
From:   "Liu, Changcheng" <changcheng.liu@intel.com>
To:     Josh Poimboeuf <jpoimboe@redhat.com>,
        Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        changcheng.liu@intel.com
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lib_backtrace: fix kernel text address leak 
Message-ID: <20171106165648.GA95243@sofia>
References: <20171106052511.GB69364@sofia>
 <20171106080528.GA1298@jagdpanzerIV>
 <20171106105203.GC69364@sofia>
 <20171106131147.ouihd4ug5ah3vb6a@treble>
 <20171106164847.GD69364@sofia>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171106164847.GD69364@sofia>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Don't leak idle function address in NMI backtrace.

Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>

diff --git a/lib/nmi_backtrace.c b/lib/nmi_backtrace.c
index 46e4c749..61a6b5a 100644
--- a/lib/nmi_backtrace.c
+++ b/lib/nmi_backtrace.c
@@ -93,8 +93,8 @@ bool nmi_cpu_backtrace(struct pt_regs *regs)
 	if (cpumask_test_cpu(cpu, to_cpumask(backtrace_mask))) {
 		arch_spin_lock(&lock);
 		if (regs && cpu_in_idle(instruction_pointer(regs))) {
-			pr_warn("NMI backtrace for cpu %d skipped: idling at pc %#lx\n",
-				cpu, instruction_pointer(regs));
+			pr_warn("NMI backtrace for cpu %d skipped: idling at %pS\n",
+				cpu, (void *)instruction_pointer(regs));
 		} else {
 			pr_warn("NMI backtrace for cpu %d\n", cpu);
 			if (regs)
-- 
2.7.4

From 1583338614296935305@xxx Mon Nov 06 17:29:30 +0000 2017
X-GM-THRID: 1583338614296935305
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread