Received: by 10.223.164.221 with SMTP id h29csp2020917wrb; Thu, 2 Nov 2017 04:46:09 -0700 (PDT) X-Google-Smtp-Source: ABhQp+Rp3LLMTBf+/w/HopFKLWhQBNfaMDOWApnBYsll6NRveKy25iiRuMW1Sp0QLs/9f7k7/W75 X-Received: by 10.99.184.25 with SMTP id p25mr3207647pge.180.1509623169129; Thu, 02 Nov 2017 04:46:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509623169; cv=none; d=google.com; s=arc-20160816; b=Q/myIts8ZpPPfmmBCSATs73Y8mtlbknB9IuSIth9BhcZYwhgif8gjn7gIdiEu7ceWk JepohHWPYqi9SCgbDyF6uWOs6r4PMt0Wkp1ayuejHeT9rF/joJIZgMBhjc6W/h6krbVV 1zXuTeI9k+QKHBdI2a6Fkc/hBdWwA1cM7gFGiI5RMMUwq1vkTgFSUazklUGx5z9EjgsY SE7z+3GBDVb8xQhyl3H3JI7X7cKfxmiZ0WPIZ677N7nGHVZtFkWMsbJRIDxLRuBN9wUV Z4EJ1POTF5TT5HPFzE5V0Di2c5+AOO5j6fQdfm4Jd1zb2WLIxLlziEtiVfodGg0hGO+v W0/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=YEIDRsMv2JH3NixTyMvPDHrzAcf05twpC5DfLDZdPtU=; b=gYvQ/5kTelkScy7h3uAOVO+HD5ZzNUfvBL87lj4au5al/ygXRxOTwJ4sxF8pufpbLt FDPMf2bD4ibcF2l0BC5yX1XwM+4jT8wTE3lfbc2Fams9bInWOhxtMnXSSSlk7lEWIJPu iRJRLL37eH8XA7GUMJQAz8Yg21asDYXRoLVOE3YfoD+cD/GqT6GHwT8jT7mPPecgyIOW WbyQm/TT1qAaTvzTrolOu9+Mlcx6oW+4w71AojUU4n6BdIXixAFjXMoHf6IJD2hXgCBf pAbbyaBeOhddkpNSloR/bG/HvUo40pmaI7VU5aHPW735l58iyMtP6uWyF6ypzW++6j/5 eYtw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f30si2197981plf.32.2017.11.02.04.45.55; Thu, 02 Nov 2017 04:46:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753960AbdKBLoK (ORCPT + 96 others); Thu, 2 Nov 2017 07:44:10 -0400 Received: from 8.mo4.mail-out.ovh.net ([188.165.33.112]:56846 "EHLO 8.mo4.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752632AbdKBLoI (ORCPT ); Thu, 2 Nov 2017 07:44:08 -0400 X-Greylist: delayed 1809 seconds by postgrey-1.27 at vger.kernel.org; Thu, 02 Nov 2017 07:44:08 EDT Received: from player746.ha.ovh.net (b6.ovh.net [213.186.33.56]) by mo4.mail-out.ovh.net (Postfix) with ESMTP id E28AEED7A2 for ; Thu, 2 Nov 2017 12:05:18 +0100 (CET) Received: from localhost.localdomain (124.149.193.77.rev.sfr.net [77.193.149.124]) (Authenticated sender: sebastien.szymanski@armadeus.com) by player746.ha.ovh.net (Postfix) with ESMTPSA id 9CEA950008E; Thu, 2 Nov 2017 12:05:12 +0100 (CET) From: =?UTF-8?q?S=C3=A9bastien=20Szymanski?= To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Benjamin Tissoires , Jiri Kosina , Julien Boibessot , =?UTF-8?q?S=C3=A9bastien=20Szymanski?= Subject: [PATCH 2/3] HID: cp2112: add HIDRAW dependency Date: Thu, 2 Nov 2017 12:12:43 +0100 Message-Id: <1509621164-28830-2-git-send-email-sebastien.szymanski@armadeus.com> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1509621164-28830-1-git-send-email-sebastien.szymanski@armadeus.com> References: <1509621164-28830-1-git-send-email-sebastien.szymanski@armadeus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 18153447148597826630 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedttddrgeeigddvtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Otherwise, with HIDRAW=n, the probe function crashes because of null dereference of hdev->hidraw. Fixes: 42cb6b35b9e6 ("HID: cp2112: use proper hidraw name with minor number") Signed-off-by: Sébastien Szymanski --- drivers/hid/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 374301f..8c7a0ce 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -230,7 +230,7 @@ config HID_CMEDIA config HID_CP2112 tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support" - depends on USB_HID && I2C && GPIOLIB + depends on USB_HID && HIDRAW && I2C && GPIOLIB select GPIOLIB_IRQCHIP ---help--- Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge. -- 2.7.3 From 1583313071748896038@xxx Mon Nov 06 10:43:31 +0000 2017 X-GM-THRID: 1583313071748896038 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread