Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 6 Nov 2017 11:00:59 +0800
From:   "Du, Changbin" <changbin.du@intel.com>
To:     Ingo Molnar <mingo@kernel.org>
Cc:     changbin.du@intel.com, hpa@zytor.com, tglx@linutronix.de,
        mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org,
        yamada.masahiro@socionext.com
Subject: Re: [PATCH 2/4] x86, build: Add new paths for isolinux.bin and
 ldlinux.c32
Message-ID: <20171106030058.GB1464@intel.com>
References: <1509873493-17929-1-git-send-email-changbin.du@intel.com>
 <1509873493-17929-3-git-send-email-changbin.du@intel.com>
 <20171105093352.okrgv3623wsjwwin@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="0ntfKIWw70PvrIHh"
Content-Disposition: inline
In-Reply-To: <20171105093352.okrgv3623wsjwwin@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--0ntfKIWw70PvrIHh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Ingo,
On Sun, Nov 05, 2017 at 10:33:53AM +0100, Ingo Molnar wrote:
>=20
> * changbin.du@intel.com <changbin.du@intel.com> wrote:
>=20
> > From: Changbin Du <changbin.du@intel.com>
> >=20
> > Recently I failed to build isoimage target, because the path of isolinu=
x.bin
> > changed to /usr/xxx/ISOLINUX/isolinux.bin, as well as ldlinux.c32 which
> > changed to /usr/xxx/syslinux/modules/bios/ldlinux.c32.
> >=20
> > This patch has a improvement of the file search:
> >   - Show a error message instead of silent fail.
> >   - Add above new paths.
>=20
> How about:
>=20
>   This patch improves the file search logic:
>     - Show an error message instead of failing silently
>     - Add the new paths listed above.
>=20
>=20
> > +		if [ $i =3D end -a -z "$isolinux" ] ; then
> > +			echo 'Need isolinux.bin, please install syslinux/isolinux'
>=20
> How about:
>=20
> 			echo 'Need an isolinux.bin file, please install syslinux/isolinux'
>
The new description is much better, will update. Thanks.

> Thanks,
>=20
> 	Ingo

--=20
Thanks,
Changbin Du

--0ntfKIWw70PvrIHh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJZ/9BqAAoJEAanuZwLnPNUmmwIAIfPYvsdiHWBc/d4tsRMaqoo
UdK8iDEnT9FB1VXnD/J1xykFIHzAbAhbPsiMtnrNogAxFyzawZ8aKgMmMZfdEUHm
b09IproWGk3Fr0SSNtf8sAtqbf1V9+onZwAoGgedDPADHvknqJ5CnpWFv0M3gT/D
ylsrA4Q4/JLrvNozz5TThAvAAf2FD3DNQF5KGhXRYs3NG4vEESXTR9uqa/zoQf3J
LZtglIh2WDuMP0YSvfME/qRUkR3tqBOOyRP97ZaQAjcOHCp/naxEee08Kczka8Bg
obkJmtgXXh9Xct7T4cZeKGXqMebKgeg0mSc3aVeXB27ZgInujKliHAWQGy4v5RA=
=VetN
-----END PGP SIGNATURE-----

--0ntfKIWw70PvrIHh--

From 1583218153379249246@xxx Sun Nov 05 09:34:50 +0000 2017
X-GM-THRID: 1583217801701896506
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread