Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net-next 4/6] net: hns3: add support for
 set_link_ksettings
To:     Florian Fainelli <f.fainelli@gmail.com>, <davem@davemloft.net>
References: <1509682710-94908-1-git-send-email-lipeng321@huawei.com>
 <1509682710-94908-5-git-send-email-lipeng321@huawei.com>
 <926ca4e8-78af-d442-38c5-bf38141051b5@gmail.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>, <salil.mehta@huawei.com>
From:   "lipeng (Y)" <lipeng321@huawei.com>
Message-ID: <7f3846c6-0725-2cae-b1e6-f4519234331a@huawei.com>
Date:   Mon, 6 Nov 2017 10:28:58 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <926ca4e8-78af-d442-38c5-bf38141051b5@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2017/11/4 3:52, Florian Fainelli wrote:
> On 11/02/2017 09:18 PM, Lipeng wrote:
>> From: Fuyun Liang <liangfuyun1@huawei.com>
>>
>> This patch adds set_link_ksettings support for ethtool cmd.
>>
>> Signed-off-by: Fuyun Liang <liangfuyun1@huawei.com>
>> Signed-off-by: Lipeng <lipeng321@huawei.com>
>> ---
>>   drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
>> index c7b8ebd..7fe193b 100644
>> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
>> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
>> @@ -653,6 +653,16 @@ static int hns3_get_link_ksettings(struct net_device *netdev,
>>   	return 0;
>>   }
>>   
>> +static int hns3_set_link_ksettings(struct net_device *netdev,
>> +				   const struct ethtool_link_ksettings *cmd)
>> +{
>> +	/* Only support ksettings_set for netdev with phy attached for now */
>> +	if (netdev->phydev)
>> +		return phy_ethtool_ksettings_set(netdev->phydev, cmd);
>> +
>> +	return -EOPNOTSUPP;
> Consider using phy_ethtool_get_link_ksettings() which already checks for
> netdev->phydev.
agree, Thanks for your comment.

as this patch has been applied to  net-next, we will push another 
cleanup patch.


From 1583075895004028493@xxx Fri Nov 03 19:53:41 +0000 2017
X-GM-THRID: 1583015474965024164
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread