Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758947AbYAPEmq (ORCPT ); Tue, 15 Jan 2008 23:42:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756873AbYAPEmi (ORCPT ); Tue, 15 Jan 2008 23:42:38 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:36786 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754436AbYAPEmh (ORCPT ); Tue, 15 Jan 2008 23:42:37 -0500 Date: Tue, 15 Jan 2008 20:42:36 -0800 From: Andrew Morton To: Fengguang Wu Cc: Michael Rubin , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch] Converting writeback linked lists to a tree based data structure Message-Id: <20080115204236.6349ac48.akpm@linux-foundation.org> In-Reply-To: <400457571.32162@ustc.edu.cn> References: <20080115080921.70E3810653@localhost> <1200386774.15103.20.camel@twins> <532480950801150953g5a25f041ge1ad4eeb1b9bc04b@mail.gmail.com> <400452490.28636@ustc.edu.cn> <20080115194415.64ba95f2.akpm@linux-foundation.org> <400457571.32162@ustc.edu.cn> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 669 Lines: 15 On Wed, 16 Jan 2008 12:25:53 +0800 Fengguang Wu wrote: > list_heads are OK if we use them for one and only function. Not really. They're inappropriate when you wish to remember your position in the list while you dropped the lock (as we must do in writeback). A data structure which permits us to interate across the search key rather than across the actual storage locations is more appropriate. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/