Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 16 Nov 2017 09:38:49 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Wanpeng Li <kernellwp@gmail.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,
        Radim Kr??m???? <rkrcmar@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>
Subject: Re: [PATCH v5 2/4] KVM: X86: Add paravirt remote TLB flush
Message-ID: <20171116083849.tvvxhu764uy5lryx@hirez.programming.kicks-ass.net>
References: <1510567280-19376-1-git-send-email-wanpeng.li@hotmail.com>
 <1510567280-19376-3-git-send-email-wanpeng.li@hotmail.com>
 <CANRm+CxjUTmCtT3V0He_c-GzAUeRcc0m2e11=OxLA8-Er+pRmw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANRm+CxjUTmCtT3V0He_c-GzAUeRcc0m2e11=OxLA8-Er+pRmw@mail.gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 16, 2017 at 01:30:57PM +0800, Wanpeng Li wrote:
> -static DEFINE_PER_CPU(cpumask_var_t, __pv_tlb_mask);
> +static DEFINE_PER_CPU(cpumask_t, __pv_tlb_mask);

NR_CPUS=512 is a fairly common distro setting, that means cpumask_t is
64 bytes. So for my 144 CPU system, that is 9216 bytes I'll never see
again.

Not nice :/

From 1584218012699172642@xxx Thu Nov 16 10:27:10 +0000 2017
X-GM-THRID: 1583909069046568739
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread