Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 31 Oct 2017 00:01:07 +0000
User-Agent: K-9 Mail for Android
In-Reply-To: <CAGXu5jJ_O5rgRL2FnpvD2WehSZ+1BBTAFjQ5R66Pc06_5M9DRw@mail.gmail.com>
References: <20171024144938.GA41224@beast> <55a6647a-8565-09e8-9f45-d9048c7dd916@linaro.org> <20171030113202.GB7223@localhost> <558a6d02-515e-9998-18cc-b9b77d2b1d63@nexus-software.ie> <20171030113819.GD7223@localhost> <523e9618-e72e-72fa-3d98-062e687ca226@linaro.org> <20171030114809.GF7223@localhost> <CAGXu5jJ_O5rgRL2FnpvD2WehSZ+1BBTAFjQ5R66Pc06_5M9DRw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()
To:     Kees Cook <keescook@chromium.org>, Johan Hovold <johan@kernel.org>
CC:     Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Alex Elder <elder@kernel.org>, greybus-dev@lists.linaro.org,
        devel@driverdev.osuosl.org
From:   pure.logic@nexus-software.ie
Message-ID: <AA0A0F6F-0E5A-43E0-A90E-B93DDFD08353@nexus-software.ie>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 30 October 2017 9:37:37 p=2Em=2E GMT+00:00, Kees Cook <keescook@chromium=
=2Eorg> wrote:
>On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold <johan@kernel=2Eorg> wrote:
>> On Mon, Oct 30, 2017 at 11:44:22AM +0000, Bryan O'Donoghue wrote:
>>>
>>>
>>> On 30/10/17 11:38, Johan Hovold wrote:
>>> > On Mon, Oct 30, 2017 at 11:35:50AM +0000, Bryan O'Donoghue wrote:
>>> >> On 30/10/17 11:32, Johan Hovold wrote:
>>> >>> The right thing to do here is to respin your patch from last
>year which
>>> >>> converts the loopback driver to use the timeout handling in
>greybus
>>> >>> core=2E
>>> >>
>>> >> Actually I wasn't clear if you wanted to to that yourself aswell
>as the
>>> >> rest if it=2E
>>> >>
>>> >> But sure I can do that conversion, it's on my list=2E
>>> >
>>> > IIRC it was basically done=2E Just some odd locking that could now
>also be
>>> > removed=2E
>>> >
>>> > Thanks,
>>> > Johan
>>> >
>>>
>>> I think once Kees' change is applied to operation=2Ec and we convert
>the
>>> async stuff to operation=2Ec's callbacks there ought to be no use of
>>> timers, linked lists of operations=2E
>>
>> That's correct=2E
>>
>>> I'll probably need at least a day to look at that, so it'll be the
>>> weekend before I can really allocate time=2E
>>
>> Cool=2E I'm quite sure I just rebased your loopback conversion patch on
>my
>> core timeout handling and used that to test the core implementation,
>so
>> it should be straight forward=2E
>
>Hi,
>
>I seem to have lost the thread of conversation a bit=2E What exactly
>remains that I should be doing here for timer conversions? (It sounded
>like it was already partially handled already?)
>
>-Kees

Trying again without top posting in html :(

Just pair the patch down to operation=2Ec=2E

There's a separate change to loopback=2Ec an old patch ARAIR that will sub=
tract use of the timer from loopback=2Ec so you can skip that bit=2E
--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E

From 1582720577787861283@xxx Mon Oct 30 21:46:05 +0000 2017
X-GM-THRID: 1582126742408023281
X-Gmail-Labels: Inbox,Category Forums