Received: by 10.223.164.221 with SMTP id h29csp14797wrb; Fri, 3 Nov 2017 09:43:39 -0700 (PDT) X-Google-Smtp-Source: ABhQp+SsnOsJcZtNJVTHXvw+yLSJdp4jIeVrxBoG1h6YBQqDcq3Rcnd2Nl2vjyuyKKINpKJzlmcx X-Received: by 10.159.234.68 with SMTP id c4mr7219174plr.52.1509727418986; Fri, 03 Nov 2017 09:43:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509727418; cv=none; d=google.com; s=arc-20160816; b=u/uxgjw+D1sCB89XRh15UdkM0UoFDGRQqNZUzETcfJ++HyXromueWN9BCWCtBN/vAS J4/SahY1YQ1TiSOfp3BUK+9xTOhizsZKlFvvaq73d/NhU3dTdSth+xbChss8rl4bHss/ Kan2BYDEv2+0QkWa16Lxc3b5FkzqmIgPIfdwJOqe5aFUZ+TZ0cxa96bd73VWXJP2U0fT OIhl3GI4GsNsLgnFaAT7LqgcvDBZyr2jABf7lt+hm1+5oFVxthB6E1FrybIHnfScIHHy 4Cnun39c1UG1BGGmbUI8pVUQy4+/oQZzOCB72HiK3xFfYCBt/JK964uufjxWDPjn2Vz4 GDvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=yQ1wluhlCpxmmKvqyQwTYmh2pYGwdh8pTHTpL6b6G3g=; b=Y/oCNSQ9HgqTR8UiZCDAxA6FjHY03snfa2Yp2CadLBwUmT4b0rnvhQrcaNTiTjfoau jv3WFQlhR1rXFHP+yyxBjMS9GdHhZNEgELaG7Hk0LDNotweScBHjgrYyn+TLy3AvW2VX 4BZaU9U3pQBZy/tfU1YH6eq72TObq7G2ZgbIKJF5M6OQoP2YJbWi0qpuCYQPUsVjO4rK hYxc/Y47eLjU+d2HvpdLZ9Rfm8txGGDlCChb1nQ79QnS0zMHmUwfq6ka+s7Mut92ED5i YaCniu5JubLOIOj4gndAd3BKXNC30slxtbXx3/Oy4fVqG2vntytaNbnpyk57EvXL4QWF JZcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t61si5103333plb.707.2017.11.03.09.43.21; Fri, 03 Nov 2017 09:43:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756043AbdKCQmY (ORCPT + 93 others); Fri, 3 Nov 2017 12:42:24 -0400 Received: from gateway24.websitewelcome.com ([192.185.51.209]:20927 "EHLO gateway24.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752425AbdKCQmX (ORCPT ); Fri, 3 Nov 2017 12:42:23 -0400 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 5A2F135206E for ; Fri, 3 Nov 2017 11:42:22 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id Af30eGp7EtuxmAf30eeSJd; Fri, 03 Nov 2017 11:42:22 -0500 Received: from [189.145.38.148] (port=49336 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1eAf2z-002mGQ-Si; Fri, 03 Nov 2017 11:42:21 -0500 Date: Fri, 3 Nov 2017 11:42:21 -0500 From: "Gustavo A. R. Silva" To: James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] scsi: lpfc_els: use swap macro in lpfc_plogi_confirm_nport Message-ID: <20171103164221.GA14017@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.145.38.148 X-Source-L: No X-Exim-ID: 1eAf2z-002mGQ-Si X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.145.38.148]:49336 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 13 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make use of the swap macro and remove unnecessary variable keep_nlp_flag. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/lpfc/lpfc_els.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index b14f7c5..1b745fe 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -1525,7 +1525,7 @@ lpfc_plogi_confirm_nport(struct lpfc_hba *phba, uint32_t *prsp, struct fc_rport *rport; struct serv_parm *sp; uint8_t name[sizeof(struct lpfc_name)]; - uint32_t rc, keepDID = 0, keep_nlp_flag = 0; + uint32_t rc, keepDID = 0; uint16_t keep_nlp_state; struct lpfc_nvme_rport *keep_nrport = NULL; int put_node; @@ -1616,9 +1616,7 @@ lpfc_plogi_confirm_nport(struct lpfc_hba *phba, uint32_t *prsp, phba->cfg_rrq_xri_bitmap_sz); spin_lock_irq(shost->host_lock); - keep_nlp_flag = new_ndlp->nlp_flag; - new_ndlp->nlp_flag = ndlp->nlp_flag; - ndlp->nlp_flag = keep_nlp_flag; + swap(new_ndlp->nlp_flag, ndlp->nlp_flag); spin_unlock_irq(shost->host_lock); /* Set nlp_states accordingly */ -- 2.7.4 From 1583361905467246448@xxx Mon Nov 06 23:39:42 +0000 2017 X-GM-THRID: 1583361905467246448 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread