Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 6 Nov 2017 01:03:43 +0100
From:   Samuel Ortiz <sameo@linux.intel.com>
To:     Colin King <colin.king@canonical.com>
Cc:     Robert Baldyga <r.baldyga@samsung.com>,
        Krzysztof Opasiak <k.opasiak@samsung.com>,
        linux-nfc@lists.01.org, linux-wireless@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfc: s3fwrn5: make array match static const, reduces
 object code size
Message-ID: <20171106000343.GC27831@zurbaran.ger.intel.com>
References: <20170919142515.23196-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170919142515.23196-1-colin.king@canonical.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Colin,

On Tue, Sep 19, 2017 at 03:25:15PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate the read-only array match on the stack, instead make
> it static const.  Makes the object code smaller by over 310 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    8304	   1084	    128	   9516	   252c	drivers/nfc/s3fwrn5/firmware.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    7894	   1180	    128	   9202	   23f2	drivers/nfc/s3fwrn5/firmware.o
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/nfc/s3fwrn5/firmware.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
Applied to nfc-next, thanks.

Cheers,
Samuel.

From 1578978461285776164@xxx Tue Sep 19 14:26:44 +0000 2017
X-GM-THRID: 1578978461285776164
X-Gmail-Labels: Inbox,Category Forums