Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 43427D9635
Date:   Fri, 3 Nov 2017 12:14:43 -0400 (EDT)
From:   =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>
To:     Mike Kravetz <mike.kravetz@oracle.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        aarcange@redhat.com, hughd@google.com, nyc@holomorphy.com
Message-ID: <1675520780.35881890.1509725683143.JavaMail.zimbra@redhat.com>
In-Reply-To: <30bfff65-4cb9-a6b6-ab31-73d767a4b8ae@oracle.com>
References: <20171031184052.25253-1-marcandre.lureau@redhat.com> <20171031184052.25253-4-marcandre.lureau@redhat.com> <30bfff65-4cb9-a6b6-ab31-73d767a4b8ae@oracle.com>
Subject: Re: [PATCH 3/6] hugetlb: expose hugetlbfs_inode_info in header
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Thread-Topic: hugetlb: expose hugetlbfs_inode_info in header
Thread-Index: Ey+RHBMPWW9+WO0ZI2i5uLeC3kkqzw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi

----- Original Message -----
> On 10/31/2017 11:40 AM, Marc-André Lureau wrote:
> > The following patch is going to access hugetlbfs_inode_info field from
> > mm/shmem.c.
> 
> The code looks fine.  However, I would prefer something different for the
> commit message.  Perhaps something like:
> 
> hugetlbfs inode information will need to be accessed by code in mm/shmem.c
> for file sealing operations.  Move inode information definition from .c
> file to header for needed access.

Ok, Does the patch get your Reviewed-by tag with that change?

thanks

From 1582907763866228360@xxx Wed Nov 01 23:21:19 +0000 2017
X-GM-THRID: 1582799626978201594
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread