Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Aleksandar Markovic <Aleksandar.Markovic@mips.com>
To:     Joe Perches <joe@perches.com>,
        Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
        "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
CC:     Miodrag Dinic <Miodrag.Dinic@mips.com>,
        Goran Ferenc <Goran.Ferenc@mips.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Douglas Leung" <Douglas.Leung@mips.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        James Hogan <James.Hogan@mips.com>,
        "Jason Cooper" <jason@lakedaemon.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Marc Zyngier <marc.zyngier@arm.com>,
        "Mauro Carvalho Chehab" <mchehab@kernel.org>,
        Miodrag Dinic <miodrag.dinic@imgtec.com>,
        Paul Burton <Paul.Burton@mips.com>,
        "Petar Jovanovic" <Petar.Jovanovic@mips.com>,
        Raghu Gandham <Raghu.Gandham@mips.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        "Thomas Gleixner" <tglx@linutronix.de>
Subject: RE: [PATCH v7 2/5] irqchip/irq-goldfish-pic: Add Goldfish PIC driver
Thread-Topic: [PATCH v7 2/5] irqchip/irq-goldfish-pic: Add Goldfish PIC
 driver
Thread-Index: AQHTU/bGIxO3y2UlSk20Itmu6UhbuaMBvl+AgADzPl0=
Date:   Fri, 3 Nov 2017 14:10:13 +0000
Message-ID: <BD3A5F1946F2E540A31AF2CE969BAEEEC19BF3@MIPSMAIL01.mipstec.com>
References: <1509639716-4787-1-git-send-email-aleksandar.markovic@rt-rk.com>
         <1509639716-4787-3-git-send-email-aleksandar.markovic@rt-rk.com>,<1509640479.31043.80.camel@perches.com>
In-Reply-To: <1509640479.31043.80.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> From: Joe Perches [joe@perches.com]
> ...
>On Thu, 2017-11-02 at 17:21 +0100, Aleksandar Markovic wrote:
> ...
>
> > Signed-off-by: Miodrag Dinic <miodrag.dinic@mips.com>
> > Signed-off-by: Goran Ferenc <goran.ferenc@mips.com>
> > Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
> > wq
> 
> vi much?
> 

:)

> > +/*
> > + * Driver for MIPS Goldfish Programmable Interrupt Controller.
> > + *
> > + * Author: Miodrag Dinic <miodrag.dinic@mips.com>
> > + *
> > + * This program is free software; you can redistribute       it and/or modify it
> > + * under  the terms of       the GNU General  Public License as published by the
> > + * Free Software Foundation;  either version 2 of the  License, or (at your
> > + * option) any later version.
> > + */
> 
> Odd mix of spaces and tabs
> 

Will be fixed in v8.

> It'd be good to add a #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> before any #include so the pr_<level> output is prefixed appropriately.

Error and info messages will be completely revised in v8.

Thanks for the review!

Aleksandar

From 1582972837905265840@xxx Thu Nov 02 16:35:39 +0000 2017
X-GM-THRID: 1582972112601312976
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread