Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop
To:     "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
        Alan Ott <alan@signal11.us>,
        Alexander Aring <alex.aring@gmail.com>
Cc:     linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>
References: <20171031063127.GA6032@embeddedor.com>
From:   Stefan Schmidt <stefan@osg.samsung.com>
Message-ID: <2d784b55-8447-7581-43a3-d42f152e045b@osg.samsung.com>
Date:   Mon, 6 Nov 2017 12:13:19 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20171031063127.GA6032@embeddedor.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Alan.

On 10/31/2017 07:31 AM, Gustavo A. R. Silva wrote:
> It seems that this is a copy/paste error and the proper bit masking is:
> BIT_TXNIE | BIT_RXIE
> 
> This issue was detected with the help of Coccinelle.
> 
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Fixes: 7d840545e5b9 ("mrf24j40: replace magic numbers")
> ---
>  drivers/net/ieee802154/mrf24j40.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index ee7084b..cf4788d 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -635,7 +635,7 @@ static void mrf24j40_stop(struct ieee802154_hw *hw)
>  
>  	/* Set TXNIE and RXIE. Disable Interrupts */
>  	regmap_update_bits(devrec->regmap_short, REG_INTCON,
> -			   BIT_TXNIE | BIT_TXNIE, BIT_TXNIE | BIT_TXNIE);
> +			   BIT_TXNIE | BIT_RXIE, BIT_TXNIE | BIT_RXIE);
>  }
>  
>  static int mrf24j40_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
> 

Could you review this and give me your ack when you are happy so I can apply it to my tree?

regards
Stefan Schmidt

From 1582754383739437497@xxx Tue Oct 31 06:43:24 +0000 2017
X-GM-THRID: 1582754383739437497
X-Gmail-Labels: Inbox,Category Forums