Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] selftests: remove obsolete kconfig fragment for
 cpu-hotplug
To:     lei.yang@windriver.com, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <1508292623-8479-1-git-send-email-lei.yang@windriver.com>
From:   Shuah Khan <shuahkh@osg.samsung.com>
Message-ID: <afb7a5bb-1b7f-93cd-9a35-ef8ab34d3c5a@osg.samsung.com>
Date:   Wed, 1 Nov 2017 16:14:54 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1508292623-8479-1-git-send-email-lei.yang@windriver.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/17/2017 08:10 PM, lei.yang@windriver.com wrote:
> From: Lei Yang <Lei.Yang@windriver.com>
> 
> Kconfig CONFIG_CPU_NOTIFIER_ERROR_INJECT has been removed since kernel 4.10
> check commit:
>     commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f
>     Author: Thomas Gleixner <tglx@linutronix.de>
>     Date:   Wed Dec 21 20:19:53 2016 +0100
> 
>         cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions
> 
>         hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(),
>         register_hotcpu_notifier(), register_cpu_notifier(),
>         __register_hotcpu_notifier(), __register_cpu_notifier(),
>         unregister_hotcpu_notifier(), unregister_cpu_notifier(),
>         __unregister_hotcpu_notifier(), __unregister_cpu_notifier()
>      <snip>
> 
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
>  tools/testing/selftests/cpu-hotplug/config | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/cpu-hotplug/config b/tools/testing/selftests/cpu-hotplug/config
> index e6ab090..d4aca2a 100644
> --- a/tools/testing/selftests/cpu-hotplug/config
> +++ b/tools/testing/selftests/cpu-hotplug/config
> @@ -1,2 +1 @@
>  CONFIG_NOTIFIER_ERROR_INJECTION=y
> -CONFIG_CPU_NOTIFIER_ERROR_INJECT=m
> 

Yes. It is removed from the kernel. However, selftests from the latest
release do get run routinely on older stable releases. Dropping the
config will impact coverage on older releases.

Thomas/Greg,

Any ideas on what we should do about this. On one hand it is a good idea
to remove it, however my concern is coverage on older releases.

thanks,
-- Shuah

From 1581601542568567111@xxx Wed Oct 18 13:19:29 +0000 2017
X-GM-THRID: 1581601542568567111
X-Gmail-Labels: Inbox,Category Forums