Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Bryan O'Donoghue <pure.logic@nexus-software.ie>
To:     johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
        devel@driverdev.osuosl.org, keescook@chromium.org,
        linux-kernel@vger.kernel.org
Cc:     Bryan O'Donoghue <pure.logic@nexus-software.ie>,
        Mitch Tasman <tasman@leaflabs.com>,
        greybus-dev@lists.linaro.org
Subject: [PATCH v2 2/4] staging: greybus: loopback: Fix iteration count on async path
Date:   Mon,  6 Nov 2017 01:26:09 +0000
Message-Id: <1509931571-24621-3-git-send-email-pure.logic@nexus-software.ie>
In-Reply-To: <1509931571-24621-1-git-send-email-pure.logic@nexus-software.ie>
References: <1509931571-24621-1-git-send-email-pure.logic@nexus-software.ie>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Commit 12927835d211 ("greybus: loopback: Add asynchronous bi-directional
support") does what it says on the tin - namely, adds support for
asynchronous bi-directional loopback operations.

What it neglects to do though is increment the per-connection
gb->iteration_count on an asynchronous operation error. This patch fixes
that omission.

Fixes: 12927835d211 ("greybus: loopback: Add asynchronous bi-directional support")

Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Reported-by: Mitch Tasman <tasman@leaflabs.com>
Cc: Johan Hovold <johan@kernel.org>
Cc: Alex Elder <elder@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mitch Tasman <tasman@leaflabs.com>
Cc: greybus-dev@lists.linaro.org
Cc: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/staging/greybus/loopback.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 20d1b45..9c5980c 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -1021,8 +1021,10 @@ static int gb_loopback_fn(void *data)
 			else if (type == GB_LOOPBACK_TYPE_SINK)
 				error = gb_loopback_async_sink(gb, size);
 
-			if (error)
+			if (error) {
 				gb->error++;
+				gb->iteration_count++;
+			}
 		} else {
 			/* We are effectively single threaded here */
 			if (type == GB_LOOPBACK_TYPE_PING)
-- 
2.7.4


From 1583053527599651242@xxx Fri Nov 03 13:58:10 +0000 2017
X-GM-THRID: 1583053527599651242
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread