Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] crypto: ccp: remove unused variable qim
To:     Colin King <colin.king@canonical.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "David S . Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org
References: <20171012165541.32256-1-colin.king@canonical.com>
Cc:     kernel-janitors@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        linux-kernel@vger.kernel.org
From:   Gary R Hook <gary.hook@amd.com>
Message-ID: <83517ed8-3dc5-4ecd-b3e1-7412e8eef472@amd.com>
Date:   Tue, 17 Oct 2017 17:12:12 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20171012165541.32256-1-colin.king@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2017 22:10:38.7728 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1322
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/12/2017 11:55 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable qim is assigned but never read, it is redundant and can
> be removed.
>
> Cleans up clang warning: Value stored to 'qim' is never read
>
> Fixes: 4b394a232df7 ("crypto: ccp - Let a v5 CCP provide the same function as v3")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Gary R Hook <gary.hook@amd.com>

> ---
>  drivers/crypto/ccp/ccp-dev-v5.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp-dev-v5.c b/drivers/crypto/ccp/ccp-dev-v5.c
> index 65604fc65e8f..44a4d2779b15 100644
> --- a/drivers/crypto/ccp/ccp-dev-v5.c
> +++ b/drivers/crypto/ccp/ccp-dev-v5.c
> @@ -788,13 +788,12 @@ static int ccp5_init(struct ccp_device *ccp)
>  	struct ccp_cmd_queue *cmd_q;
>  	struct dma_pool *dma_pool;
>  	char dma_pool_name[MAX_DMAPOOL_NAME_LEN];
> -	unsigned int qmr, qim, i;
> +	unsigned int qmr, i;
>  	u64 status;
>  	u32 status_lo, status_hi;
>  	int ret;
>
>  	/* Find available queues */
> -	qim = 0;
>  	qmr = ioread32(ccp->io_regs + Q_MASK_REG);
>  	for (i = 0; i < MAX_HW_QUEUES; i++) {
>
>

From 1581071707245578455@xxx Thu Oct 12 16:57:59 +0000 2017
X-GM-THRID: 1581071707245578455
X-Gmail-Labels: Inbox,Category Forums