Received: by 10.223.164.221 with SMTP id h29csp2524583wrb; Thu, 2 Nov 2017 12:24:15 -0700 (PDT) X-Google-Smtp-Source: ABhQp+SxOEzhnXxru1FwXN+Fu6umFkey1xsumSms0KPdt1uQv49XXQsakuC6aO+N1H/+e14Nr6to X-Received: by 10.101.80.195 with SMTP id s3mr4614887pgp.19.1509650655405; Thu, 02 Nov 2017 12:24:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509650655; cv=none; d=google.com; s=arc-20160816; b=Djq0Po3fTOZ6CumOXb6JXv7OWpgaZ2ZhY0Ksc3+e+agwcEIeg6WdrsTY5teGTj82vD gH5OgAqhrvqtRPGQqVQjXuBBh+DZMAuqCa+DQWW0b7RMghj/kthUx3iwn0af6icdt/2G ENvdoh+UGkgEO+Pb90+vgpovczZrN8Nxj/TRg0AfyQzbfpuSOG4pYl30fNw9ZsTbOIHq VnTit1jUDVN5NY6iJ0ksqN6omUUcZ8yizPjNcwLo/iaAo3/FJtFDt5o9/HTMwpp9i3BD ZF1yGzIxiCtOE4Rn6W2vKNhpnhdMAPMOuy25rUkH96vrbL1s5L5HWTG4HmP4vjOmEkCc iMYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=L5NMBYXX5LYxrgXCiiIZIbY46daIHswgiCIEhbKFiXM=; b=XohO1hhwJ/uRMHJN7oH6ppUzunWnP3BNMxOVtc2bE2uDWTcn1mG+d6MX/ZsmE3yORD 7/0AFS3SUWG6COv+NPyU2gR43i4VShLrFQS+hRSwSBJmOQeVkY41ek62xLAIo2i+Hkgp Yi2zh52NhYYJ3dCXa6Yy54lgWCBBoIJRm7q8PNscHBLJF6L+3yL5XV+Y+sAZZNkvhOmK RLMTiu1iVYYmVey9HekFfwJmZIAVr3aDOkSFyrkD+nBD1ZsQaKwTOXimqq5l7PxdM3AF B78sXCdhjFXvmpof0RvgdG1YCO6bkPHPr0qhwjYLYV79Xw2o019PUrsR6XzM8XYYZF6z UzQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3si4477789pgd.443.2017.11.02.12.24.02; Thu, 02 Nov 2017 12:24:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934355AbdKBTVm (ORCPT + 97 others); Thu, 2 Nov 2017 15:21:42 -0400 Received: from gateway30.websitewelcome.com ([192.185.144.21]:33353 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934334AbdKBTVl (ORCPT ); Thu, 2 Nov 2017 15:21:41 -0400 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 38E6CC986 for ; Thu, 2 Nov 2017 14:21:40 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id AL3cez90FtuxmAL3ceMvmd; Thu, 02 Nov 2017 14:21:40 -0500 Received: from [189.145.38.148] (port=39660 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1eAL3b-000xk3-Q4; Thu, 02 Nov 2017 14:21:39 -0500 Date: Thu, 2 Nov 2017 14:21:36 -0500 From: "Gustavo A. R. Silva" To: Wim Van Sebroeck , Guenter Roeck Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] watchdog: advantechwdt: mark expected switch fall-through Message-ID: <20171102192136.GA19474@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.145.38.148 X-Source-L: No X-Exim-ID: 1eAL3b-000xk3-Q4 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.145.38.148]:39660 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I replaced "Fall" with a proper "fall through" comment, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva --- drivers/watchdog/advantechwdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/advantechwdt.c b/drivers/watchdog/advantechwdt.c index 7d7db0c..f619443 100644 --- a/drivers/watchdog/advantechwdt.c +++ b/drivers/watchdog/advantechwdt.c @@ -181,7 +181,7 @@ static long advwdt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) if (advwdt_set_heartbeat(new_timeout)) return -EINVAL; advwdt_ping(); - /* Fall */ + /* fall through */ case WDIOC_GETTIMEOUT: return put_user(timeout, p); default: -- 2.7.4 From 1583310745970580230@xxx Mon Nov 06 10:06:33 +0000 2017 X-GM-THRID: 1583310271237489197 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread