Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 3 Nov 2017 13:47:32 -0400 (EDT)
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Roger Quadros <rogerq@ti.com>
cc:     balbi@kernel.org, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB: dummy-hcd: don't set gadget.speed in dummy_hub_control()
In-Reply-To: <1509708195-25699-1-git-send-email-rogerq@ti.com>
Message-ID: <Pine.LNX.4.44L0.1711031347180.1743-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 3 Nov 2017, Roger Quadros wrote:

> There will never be a case when gadget.speed isn't already
> USB_SPEED_FULL if connection is not USB-3 and gadget.speed
> is not USB_SPEED_HIGH or USB_SPEED_LOW.
> 
> Remove the unnecessary code.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  drivers/usb/gadget/udc/dummy_hcd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
> index c42ca8e..41cefc5 100644
> --- a/drivers/usb/gadget/udc/dummy_hcd.c
> +++ b/drivers/usb/gadget/udc/dummy_hcd.c
> @@ -2166,8 +2166,6 @@ static int dummy_hub_control(
>  							USB_PORT_STAT_LOW_SPEED;
>  						break;
>  					default:
> -						dum_hcd->dum->gadget.speed =
> -							USB_SPEED_FULL;
>  						break;
>  					}
>  				}

Acked-by: Alan Stern <stern@rowland.harvard.edu>


From 1583043878021258582@xxx Fri Nov 03 11:24:48 +0000 2017
X-GM-THRID: 1583043878021258582
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread