Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCHv2 1/1] [tools]: android/ion: userspace test utility for
 ion buffer sharing
To:     Pintu Kumar <pintu.ping@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Pintu Kumar <pintu_agarwal@yahoo.com>
References: <1506449281-8790-1-git-send-email-pintu.ping@gmail.com>
 <1507049339-16963-1-git-send-email-pintu.ping@gmail.com>
 <414b44ec-6500-c3e5-f8ca-ce1d21a3eb58@redhat.com>
 <CAOuPNLh8+-gEia41fB1Ok6NSJnhWG=dxCRR8KcfNiQSMRb3-ng@mail.gmail.com>
From:   Laura Abbott <labbott@redhat.com>
Message-ID: <10929681-0816-18d5-1bcb-5616462eecb2@redhat.com>
Date:   Wed, 4 Oct 2017 15:07:21 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <CAOuPNLh8+-gEia41fB1Ok6NSJnhWG=dxCRR8KcfNiQSMRb3-ng@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/04/2017 04:29 AM, Pintu Kumar wrote:
> The whole thing about this test is to share an FD over 2 independent processes.
> I think sharing an FD using fork() [parent/child] is not a real use
> case scenarios.
> Some people may not like the fork example.
> Initially when I started with ION, I also needed an FD sharing mechanism between
> 2 different process. Thus I came up with this framework using ipcsocket.
> Later, if required, we can even replace this with binder_ipc for
> android use cases.
> Anyways, binder_ipc also internally uses the same concept as this ipcsocket.
> To reduce the pain, we can invoke both the tests from a single shell scripts.
> I will try to include the same in kselftests, if possible.
> 
> If fork example is really required, we can add another test for it.
> This is my opinion.

You don't have to treat them as parent/child. Once they've forked
the processes are independent so you can use the same socket behavior
you've implemented here. I prefer the fork behavior over the shell
script because it means I only need to copy one file vs. three if
I'm testing in other environments but I'm not that opposed.

Thanks,
Laura

From 1580326320135552229@xxx Wed Oct 04 11:30:23 +0000 2017
X-GM-THRID: 1579656416160844925
X-Gmail-Labels: Inbox,Category Forums