Received: by 10.223.164.221 with SMTP id h29csp2635760wrb; Thu, 2 Nov 2017 14:31:48 -0700 (PDT) X-Google-Smtp-Source: ABhQp+TonwVf1NCiMM+STckf5rNlKAG8dLcySph+RmYOQO8fEyJ1ATIoxUNd8O0Un7MeR7tPTkb5 X-Received: by 10.101.64.11 with SMTP id f11mr4978317pgp.217.1509658308632; Thu, 02 Nov 2017 14:31:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509658308; cv=none; d=google.com; s=arc-20160816; b=YI1uITSqkXLhosmPK0f+gRNr8oSS3mDaTeuE+gdTHXEK9aeYzyeCJNJfljfL1WET0r 3t0Uu+G1ipUdWtXRDpwVPzz8pdNxy7cI1/cyAVlzKxu7qfq2dPbfi55yOCN0kym+9FLH BPpIDzZwVvzR9JJU4s9TUQyOqjl8tuaiA1Y0B+b/J9J9PoEqnXmQtEXnOjNXZYV0HJZg 7BeDRyVSJGh4CYchfUGf2i2y/1cxqxuuzZwguR4FNudcVzVMoIpvprCn5k4h5OAakybu oHDloBsh8lliPywd6CWcaTl+k4zBEVu8EqzaXtjSXZP14GXPD2s92iefl0O6z3jysVAg b6ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-transfer-encoding :mime-version:subject:cc:to:references:in-reply-to:from:organization :dmarc-filter:arc-authentication-results; bh=7/1UxFu1sB/46AHQOIqZzBIfLxnun4BgOn9gh3AcV84=; b=LrAiHOIO1iXpuyWkDNekIb1ZifCkSgxvK4znRDbNdPJFIbreQ0xl2G+7aEXKaVYqN7 xY1tMAH5sP/XZURrGlmYiEYn2nRyenBfWFgtSaKpiPkuoECKzysb+Z0XzfZRtjgD+VHm bS6a7KyZ4V9jfmgwkkZWYXx1DaD0tWInN7kqsBJT/kBPl/f43L91npIOlsTb8XdPjSDb 3ikZbH0kESioS/pmiEK5wJmsSG+KaNcLNi6vZ/oC0gTzIUf9YZP87iGfpoI/TIqQ0TTh kPdXgAej7N1Dw/WLG9IKg+WoqXsXXHsfxdKnlgGM4Id0PNXHjLuxh5ChpydA5rgL8Od4 ZsoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 71si3282664plc.768.2017.11.02.14.31.35; Thu, 02 Nov 2017 14:31:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965011AbdKBVaQ convert rfc822-to-8bit (ORCPT + 99 others); Thu, 2 Nov 2017 17:30:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60812 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964928AbdKBVaO (ORCPT ); Thu, 2 Nov 2017 17:30:14 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 27EA04E02B; Thu, 2 Nov 2017 21:30:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 27EA04E02B Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dhowells@redhat.com Received: from warthog.procyon.org.uk (ovpn-121-14.rdu2.redhat.com [10.10.121.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 45FB15C54C; Thu, 2 Nov 2017 21:30:12 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1509650031.3507.20.camel@linux.vnet.ibm.com> References: <1509650031.3507.20.camel@linux.vnet.ibm.com> <1509130095.3716.13.camel@linux.vnet.ibm.com> <150842463163.7923.11081723749106843698.stgit@warthog.procyon.org.uk> <150842465546.7923.6762214527898273559.stgit@warthog.procyon.org.uk> <20240.1509643356@warthog.procyon.org.uk> To: Mimi Zohar Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk, linux-efi@vger.kernel.org, matthew.garrett@nebula.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, jforbes@redhat.com Subject: Re: [PATCH 03/27] Enforce module signatures if the kernel is locked down MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Date: Thu, 02 Nov 2017 21:30:11 +0000 Message-ID: <12321.1509658211@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 02 Nov 2017 21:30:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mimi Zohar wrote: > By this point, IMA-appraisal has already verified the kernel module > signature back in kernel_read_file_from_fd(), if it was required. >  Having a key with which to verify the appended signature or requiring > an appended signature, should not be required as well. I guess I don't need to put in any support for IMA here, then, and you've taken care of it in your patchset such that it won't actually go into module_sig_check() in that case (or will at least return immediately). David From 1582982856282642877@xxx Thu Nov 02 19:14:53 +0000 2017 X-GM-THRID: 1581705993536835286 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread