Received: by 10.223.164.221 with SMTP id h29csp2813706wrb; Mon, 30 Oct 2017 10:01:57 -0700 (PDT) X-Google-Smtp-Source: ABhQp+QKNR2PXYp6dvzZhY2EKifpnDnraKZq5IQiB7wrVG64c848qXSyBLltOasfKNnewlZ2r6fT X-Received: by 10.159.218.142 with SMTP id w14mr8156117plp.310.1509382917742; Mon, 30 Oct 2017 10:01:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509382917; cv=none; d=google.com; s=arc-20160816; b=Yjc22gMnU2RRewaUFDMYff4gYfUOe5TaGbzpWG2Fvvz/nelfBXXK6O7Bi+X/oLeHio /ogFaNJR6qtk9rmR5a7FEeX9IGgxAI0GKTXuKr7TOo2cUoPgwjt+Hn5YVj3SgA8183EW xOyHR7VExTWZRE/ModfGltLNcwoXNriinL4w2bd2BmQHNQEamNP/rILrvosbCjQR5OcX aghI9IcL/g+13ir221p2cm/WRNI4Yov6otavmfuI5DfzobCqg2VjHUTZdG59vU0EDU3n wGYtIh8cil01O5zdUJfx5BBbr5ILkPLD6W1/u6YEdJdsSCTEyWuD1UBkKcErYrIkdnKr PJhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-transfer-encoding :mime-version:subject:cc:to:references:in-reply-to:from:organization :dmarc-filter:arc-authentication-results; bh=wyuF/PVc6N+4MafEt39QHmbvqP7wRksoqp+uiXcpXrg=; b=JEisx7m5CEFBXfFgIK3aBaFIMAKpKJtqc9lLxcFC1QnrEDFuMyld2TGCJidRuV5YHY vD8/wFCOPnf1EbT4TawjAEFi2bswr9V2lNxaa5/47XFSlN38fid3Cii/CeS1AqC0XxCU 87dcNcuaSKx0HNPWf8xIzp8gp+mJVpTsleqk3Wi8Wv/VZrUd1i5OTQqfMrgVg48CQF86 xEPZuRiS0vU+GS4Ilq2bCMes10m11yTzYQUIGLKHurnosKG/BgmbAu/QmDNqy81WCPRB 2EdbzLF4SIu5t45I72cCOyZDQJMnEn/mLxwmKU8+tHgah70syaFLVTSQt4/CQCOQ8mc7 v7Kw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 198si10401246pge.119.2017.10.30.10.01.43; Mon, 30 Oct 2017 10:01:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932507AbdJ3RAi convert rfc822-to-8bit (ORCPT + 99 others); Mon, 30 Oct 2017 13:00:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56930 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932348AbdJ3RAg (ORCPT ); Mon, 30 Oct 2017 13:00:36 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 69CEAC058ED2; Mon, 30 Oct 2017 17:00:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 69CEAC058ED2 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dhowells@redhat.com Received: from warthog.procyon.org.uk (ovpn-120-62.rdu2.redhat.com [10.10.120.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id C5203600C9; Mon, 30 Oct 2017 17:00:34 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1509130095.3716.13.camel@linux.vnet.ibm.com> References: <1509130095.3716.13.camel@linux.vnet.ibm.com> <150842463163.7923.11081723749106843698.stgit@warthog.procyon.org.uk> <150842465546.7923.6762214527898273559.stgit@warthog.procyon.org.uk> To: Mimi Zohar Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk, linux-efi@vger.kernel.org, matthew.garrett@nebula.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, jforbes@redhat.com Subject: Re: [PATCH 03/27] Enforce module signatures if the kernel is locked down MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Date: Mon, 30 Oct 2017 17:00:34 +0000 Message-ID: <3565.1509382834@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 30 Oct 2017 17:00:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mimi Zohar wrote: > This kernel_is_locked_down() check is being called for both the > original and new module_load syscalls.  We need to be able > differentiate them.  This is fine for the original syscall, but for > the new syscall we would need an additional IMA check - > !is_ima_appraise_enabled(). IMA can only be used with finit_module()? David From 1582437665954608591@xxx Fri Oct 27 18:49:19 +0000 2017 X-GM-THRID: 1581705993536835286 X-Gmail-Labels: Inbox,Category Forums