Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] buffer: Avoid setting buffer bits that are already set
To:     kemi <kemi.wang@intel.com>, Andi Kleen <ak@linux.intel.com>
Cc:     Jan Kara <jack@suse.cz>, Darrick J Wong <darrick.wong@oracle.com>,
        Eric Biggers <ebiggers@google.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        Jeff Layton <jlayton@redhat.com>,
        Dave <dave.hansen@linux.intel.com>,
        Andi Kleen <andi.kleen@intel.com>,
        Tim Chen <tim.c.chen@intel.com>,
        Ying Huang <ying.huang@intel.com>,
        Aaron Lu <aaron.lu@intel.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>
References: <1508772444-27879-1-git-send-email-kemi.wang@intel.com>
 <e2953a84-31d1-fdd2-faf8-62967a9f29c6@kernel.dk>
 <f475ae05-733d-b0a2-cadc-a5913f521153@intel.com>
 <87h8upxrvy.fsf@linux.intel.com>
 <131ef377-7edb-738c-4ed1-debac7857434@intel.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <5677e6be-38ab-edb3-36db-094452c61d1e@kernel.dk>
Date:   Tue, 24 Oct 2017 07:50:27 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <131ef377-7edb-738c-4ed1-debac7857434@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/23/2017 07:25 PM, kemi wrote:
> 
> 
> On 2017年10月24日 09:21, Andi Kleen wrote:
>> kemi <kemi.wang@intel.com> writes:
>>>
>>> I'll see if I can find some
>>>> time to implement the above in a nice way.
>>>
>>> Agree. Maybe something like test_and_set_bit() would be more suitable.
>>
>> test_and_set_bit is a very different operation for the CPU because
>> it is atomic for both. But we want the initial read to not
>> be atomic.
>>
> 
> I meant to express the meaning of test before setting bit.
> Apologize to make you confused.

That's why I suggested something like set_bit_if_not_set(),
test_and_set_bit() is both already used and has entirely
different semantics.

-- 
Jens Axboe


From 1582100376205892851@xxx Tue Oct 24 01:28:14 +0000 2017
X-GM-THRID: 1582062716863867471
X-Gmail-Labels: Inbox,Category Forums