Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] buffer: Avoid setting buffer bits that are already set
To:     Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
        Darrick J Wong <darrick.wong@oracle.com>,
        Eric Biggers <ebiggers@google.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        Jeff Layton <jlayton@redhat.com>
Cc:     Dave <dave.hansen@linux.intel.com>,
        Andi Kleen <andi.kleen@intel.com>,
        Tim Chen <tim.c.chen@intel.com>,
        Ying Huang <ying.huang@intel.com>,
        Aaron Lu <aaron.lu@intel.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>
References: <1508772444-27879-1-git-send-email-kemi.wang@intel.com>
 <e2953a84-31d1-fdd2-faf8-62967a9f29c6@kernel.dk>
From:   kemi <kemi.wang@intel.com>
Message-ID: <f475ae05-733d-b0a2-cadc-a5913f521153@intel.com>
Date:   Tue, 24 Oct 2017 08:52:22 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <e2953a84-31d1-fdd2-faf8-62967a9f29c6@kernel.dk>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2017年10月24日 00:19, Jens Axboe wrote:
> On 10/23/2017 10:27 AM, Kemi Wang wrote:
>> It's expensive to set buffer flags that are already set, because that
>> causes a costly cache line transition.
>>
>> A common case is setting the "verified" flag during ext4 writes.
>> This patch checks for the flag being set first.
>>
>> With the AIM7/creat-clo benchmark testing on a 48G ramdisk based-on ext4
>> file system, we see 3.3%(15431->15936) improvement of aim7.jobs-per-min on
>> a 2-sockets broadwell platform.
>>
>> What the benchmark does is: it forks 3000 processes, and each  process do
>> the following:
>> a) open a new file
>> b) close the file
>> c) delete the file
>> until loop=100*1000 times.
>>
>> The original patch is contributed by Andi Kleen.
> 
> We discussed this recently, in reference to this commit:
> 
> commit 7fcbbaf18392f0b17c95e2f033c8ccf87eecde1d
> Author: Jens Axboe <axboe@fb.com>
> Date:   Thu May 22 11:54:16 2014 -0700
> 
>     mm/filemap.c: avoid always dirtying mapping->flags on O_DIRECT
> 
> which made a massive difference, as the changelog details.
> 
> blk-mq uses this extensively as well, where possible. The problem is
> that it always has to be explained, hence the recent discussion was
> around perhaps adding
> 
> set_bit_if_not_set()
> clear_bit_if_set()
> 
> or similar functions, to document in a single location why this matters.
> Additionally, some archs may be able to implement that in an efficient
> manner.
> 
> You can add my reviewed-by to the below, 

Thanks.

I'll see if I can find some
> time to implement the above in a nice way.

Agree. Maybe something like test_and_set_bit() would be more suitable.

 In the mean time, you may
> want to consider adding a comment to the function explaining why you
> have done it that way.
> 

Sure.

From 1582065922418270496@xxx Mon Oct 23 16:20:37 +0000 2017
X-GM-THRID: 1582062716863867471
X-Gmail-Labels: Inbox,Category Forums