Received: by 10.223.164.221 with SMTP id h29csp2260260wrb; Thu, 2 Nov 2017 08:12:38 -0700 (PDT) X-Google-Smtp-Source: ABhQp+Qlx4u4nQkFKEfd+x7m4v+Hrtz6WeCSwwb0ry8mCgmPeB9qmzKpTFy6x43eThlWw1AbPV3p X-Received: by 10.84.238.1 with SMTP id u1mr3553718plk.396.1509635558552; Thu, 02 Nov 2017 08:12:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509635558; cv=none; d=google.com; s=arc-20160816; b=p/iYjkaPAnOy0u9ApaJfDd1lOsuMUNSTlii/pdEPrJvjMW0H4cSZOTmNz+l1JwI6cr 8RuuiR87uolRQNv5nWg1okyuJmHKd9jXQlacy4YyFxwtz4U/6HvLNDg7HPV9FZyJAG2/ wcJLR9A1YQMlnYboouLfoVqkoOwKWVc1Kp3rOBpm/soj4swd3sHejIyyBcxzd0PWO8lc G5Zr8RFii7WE/I4Zb5VHb+pNwTzvPTyhONib4rBXbwBTlDe76UYKqOkFD6Jga4QesBWy bFfn0OvhxJB6nHALru0k/HFrayIGKmCCyzIIHPJzu/WuAR/F+dW6VCWOw+nIcBqiNzX7 s/qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=f4izx4wCJQKwYgatRhtqRP4E3tz6Nmu7sYRn/4zy4TM=; b=Pbk4YjXcN3N3AqXBwMMv/+QC4X+WtPASeoLjlJpfnq4gGQoXgdB6hdGrOBQllAOMEP R8dFUYKNsb52LL6Ec4QipLt13JURAZdu/edGqn4+fqyu+67HzmLAlPEPskSemgwPkScR jLybHDd1r899OdKwyHpwUDqbqW/r/hHfG+4K4OQ+kF693F1R0PVIjaF1nN+93P2jE8Ll /Fjt79E0O+LED2iY03JHynp3pfV+NsUp0fBitwhuO8Vccx03hkefOW5JKV/eHUV+l6sv WTuy3DsDcYTcbgv8oY7Yyaz6tADtUg1HsNzBpPiLY5Q3xiRn6SzX2hh67Xkz+EG50cMr xvYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=1iYgJ4B6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p6si1580771pgf.114.2017.11.02.08.12.24; Thu, 02 Nov 2017 08:12:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=1iYgJ4B6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933773AbdKBPLP (ORCPT + 97 others); Thu, 2 Nov 2017 11:11:15 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:45323 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932724AbdKBPLM (ORCPT ); Thu, 2 Nov 2017 11:11:12 -0400 Received: by mail-io0-f170.google.com with SMTP id i38so14736831iod.2 for ; Thu, 02 Nov 2017 08:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=f4izx4wCJQKwYgatRhtqRP4E3tz6Nmu7sYRn/4zy4TM=; b=1iYgJ4B6GVrv2ZYD9mQ0ds0tAmv8m+/a6gsRFoNImRX8cJoAPQ3QWURW11MrBIA0CU gXkWbecv0f4ALDv/P8RmXVCeUAXv1D/JzUn0Wgn6mnRDaAAUQobCRGt+kFS+ZS0Tm8fG v7wV+vehgWd9FYt+h8nuQ6LKjed+Wo/Bov1kwfdAvRvhBrRwmMjW8JM9cOEvOP+mTvkt 8LEVXm44wkEMFLwftFCV0AKYbV9+ilmtgA0T3UEZLhbhcLXITBoEDj6O52XoJdNIpRBJ x9VQR5m3D4wR649xZytzXhxvRz1tSfpDIuBjH2C/FLHTl5H2YiErNWR3ER+RyyJJD0S5 mVAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=f4izx4wCJQKwYgatRhtqRP4E3tz6Nmu7sYRn/4zy4TM=; b=LONexg/i2z+FFRbKuwl8mpQ4y3sL4QtiIetzzh4Fg743vvKU5kaU2feYOmtHihu1OB nF86SWcnlOp7ponVro+9bvyhXI69xSTHDHVApaX7OzXMks9neqTw5U7UyWLNt/ZskUFs VDPmkk8VKvFhu+5LzI+EPMEVZ3qMqZVxnBuYxpexjylZqLT9jpJadF5Q6G46f6xpGulw hkFM6EyLeDrZLnLJPH2AA8SzpHRV2ONceotJTuBPvqD7XG5D8CiHlLIcAcBWPFmcPgPb bStubY9MRgEL2HZftkdwM7j3J+004eNJfxQ65995bSenbBH0h4nRqtGx0SsvIjGcGFXx Pl0g== X-Gm-Message-State: AJaThX7u0OejQIbxPzvZftQO2PdVPmYtRxmGX07Abl9dSLsuuhG2V/Wc 4LdNAwaYIO6dGUq4UhrgIlXVcQ== X-Received: by 10.107.20.203 with SMTP id 194mr4858518iou.6.1509635471568; Thu, 02 Nov 2017 08:11:11 -0700 (PDT) Received: from [192.168.1.154] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id 14sm1648940iod.33.2017.11.02.08.11.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Nov 2017 08:11:10 -0700 (PDT) Subject: Re: [PATCH] block: fix CDROM dependency on BLK_DEV To: Bart Van Assche , "arnd@arndb.de" Cc: "jejb@linux.vnet.ibm.com" , "davem@davemloft.net" , "linux-kernel@vger.kernel.org" , "hare@suse.com" , "martin.petersen@oracle.com" , "linux-ide@vger.kernel.org" , "linux-scsi@vger.kernel.org" References: <20171102111952.4021454-1-arnd@arndb.de> <212c24f4-7329-f1f5-93c8-090727ed7226@kernel.dk> <1509634878.2484.5.camel@wdc.com> From: Jens Axboe Message-ID: Date: Thu, 2 Nov 2017 09:11:04 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1509634878.2484.5.camel@wdc.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2017 09:01 AM, Bart Van Assche wrote: > On Thu, 2017-11-02 at 08:27 -0600, Jens Axboe wrote: >> On 11/02/2017 05:19 AM, Arnd Bergmann wrote: >>> After the cdrom cleanup, I get randconfig warnings for some configurations: >>> >>> warning: (BLK_DEV_IDECD && BLK_DEV_SR) selects CDROM which has unmet direct dependencies (BLK_DEV) >>> >>> This adds an explicit BLK_DEV dependency for both drivers. The other >>> drivers that select 'CDROM' already have this and don't need a change. >> >> Thanks Arnd, applied. > > Hello Jens, > > Can you wait at least 24 hours after a patch has been posted before applying it > such those who want to post review comments have a chance to do that? I generally at least do that, unless they are trivial... -- Jens Axboe From 1582967317449076158@xxx Thu Nov 02 15:07:54 +0000 2017 X-GM-THRID: 1582953154006260596 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread