Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Liang, Kan" <kan.liang@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     "peterz@infradead.org" <peterz@infradead.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "acme@kernel.org" <acme@kernel.org>,
        "eranian@google.com" <eranian@google.com>,
        "ak@linux.intel.com" <ak@linux.intel.com>
Subject: RE: [PATCH V3 1/5] perf/x86/intel/uncore: customized pmu event read
 for client IMC uncore
Thread-Topic: [PATCH V3 1/5] perf/x86/intel/uncore: customized pmu event
 read for client IMC uncore
Thread-Index: AQHTTPn8N2Thg1PlBU23gMJh7UBtUqMAoguAgACGaBD//3vBgIAAAViAgACGcoD//3zEgIAAAYeAgACG4uD//4RegAAQ3Stw//+E6gD//3lXsA==
Date:   Thu, 2 Nov 2017 15:57:22 +0000
Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077537DCB8B@SHSMSX103.ccr.corp.intel.com>
References: <1508843124-4081-1-git-send-email-kan.liang@intel.com>
 <alpine.DEB.2.20.1711021446030.2090@nanos>
 <37D7C6CF3E00A74B8858931C1DB2F077537DCA04@SHSMSX103.ccr.corp.intel.com>
 <alpine.DEB.2.20.1711021453550.2090@nanos>
 <alpine.DEB.2.20.1711021458390.2090@nanos>
 <37D7C6CF3E00A74B8858931C1DB2F077537DCA32@SHSMSX103.ccr.corp.intel.com>
 <alpine.DEB.2.20.1711021510060.2090@nanos>
 <alpine.DEB.2.20.1711021513400.2090@nanos>
 <37D7C6CF3E00A74B8858931C1DB2F077537DCA69@SHSMSX103.ccr.corp.intel.com>
 <alpine.DEB.2.20.1711021530250.2090@nanos>
 <37D7C6CF3E00A74B8858931C1DB2F077537DCB0D@SHSMSX103.ccr.corp.intel.com>
 <alpine.DEB.2.20.1711021636540.2090@nanos>
In-Reply-To: <alpine.DEB.2.20.1711021636540.2090@nanos>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> On Thu, 2 Nov 2017, Liang, Kan wrote:
> > > On Thu, 2 Nov 2017, Liang, Kan wrote:
> > > > > On Thu, 2 Nov 2017, Thomas Gleixner wrote:
> > > > > But then you have this in uncore_perf_event_update():
> > > > >
> > > > > -       if (event->hw.idx >= UNCORE_PMC_IDX_FIXED)
> > > > > +       if (event->hw.idx == UNCORE_PMC_IDX_FIXED)
> > > > >
> > > > > So how is that supposed to work?
> > > >
> > > > This is for generic code.
> > > >
> > > > In previous code, the event_read function for IMC use generic code.
> > > > So we have to deal with >= in generic code.
> > > >
> > > > Now, customized event_read function 'snb_uncore_imc_event_read'
> > > >  is introduced for IMC. So IMC does not touch the generic code.
> > > > The generic code is corrected here.
> > >
> > > The customized read function does not help at all.
> > >
> > > uncore_perf_event_update() is used from snb_uncore_imc_event_stop().
> So
> > > it's broken with this patch.
> >
> > Right, need to use the customized read function to replace it as well.
> > I will fix it in next version.
> >
> > >
> > > This is a complete and utter mess to review.
> >
> > Most of the customized functions will be clean up after the series is applied.
> 
> Correct, but please try to split 2/5 into parts as well. It's a hodgepodge
> of new things and modifications to the code. The logical split is to add
> the new data structures and struct members along with the inline helpers
> and then in the next patch make use of it.
>

Sure, I will do that.

Also, I just noticed that the '>=' is used in nhmex_uncore_msr_enable_event
as well, which does not make sense and unnecessary.
For Nehalem and Westmere, there is only one fixed counter for W-Box.
It's nhm specific issue, not related to generic code.
I will also clean it up in next version. 
 
Thanks,
Kan


From 1582969362732626401@xxx Thu Nov 02 15:40:24 +0000 2017
X-GM-THRID: 1582166476632080836
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread